Bug 698740

Summary: Version bump needed for tcp_wrappers
Product: [Fedora] Fedora Reporter: Philip Prindeville <philipp>
Component: tcp_wrappersAssignee: Petr Lautrbach <plautrba>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: unspecified    
Version: rawhideCC: philipp, rvokal, vhercing
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: ftp://ftp.porcupine.org/pub/security/tcp_wrappers_7.6-ipv6.4.tar.gz
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-31 15:40:35 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Update to official IPv6 codebase none

Description Philip Prindeville 2011-04-21 16:31:41 UTC 
Description of problem:

The current Fedora package is based on the initial release of tcp_wrappers 7.6 from Wietse.  Since then, an intermediate (re-)release of that same version with IPv6 came out.

The Fedora packaging uses a series of patches to add IPv6.

Releasing based on this (re-)release would eliminate a few patches:

ftp://ftp.porcupine.org/pub/security/tcp_wrappers_7.6-ipv6.4.tar.gz

I spoke to Wietse recently and he said its not impossible that another release of tcp_wrappers might come out (even though the last one was 14 years ago).

Version-Release number of selected component (if applicable):

7.6-60

How reproducible:

N/A

Steps to Reproduce:
1.
2.
3.
  
Actual results:

N/A


Expected results:

N/A

Additional info:
Comment 1 Fedora Admin XMLRPC Client 2011-11-30 12:24:21 UTC 
This package has changed ownership in the Fedora Package Database.  Reassigning to the new owner of this component.
Comment 2 Philip Prindeville 2012-09-26 23:30:32 UTC 
hello?
Comment 3 Petr Lautrbach 2012-10-01 08:01:29 UTC 
There are several conflicts in existing patches and the new tcp_wrappers_7.6-ipv6.4.tar.gz code which need to be solved. I'm working on it and I'll send soon (definitely before F18 Beta) rebased package for testing.
Comment 4 Viktor Hercinger 2013-01-25 13:51:10 UTC 
I tried to compile the vanilla ipv6 version of tcp_wrappers, but it failed:

$ make REAL_DAEMON_DIR=/usr/bin IPV6=-DHAVE_IPV6 linux
...
cc -O -DFACILITY=LOG_MAIL	 -DHOSTS_ACCESS -DPARANOID  -DGETPEERNAME_BUG -DBROKEN_FGETS -DLIBC_CALLS_STRTOK   -DDAEMON_UMASK=022 -DREAL_DAEMON_DIR=\"/usr/bin\"   -DSEVERITY=LOG_INFO	 -DRFC931_TIMEOUT=10  -DHOSTS_DENY=\"/etc/hosts.deny\" -DHOSTS_ALLOW=\"/etc/hosts.allow\"   -DBROKEN_SO_LINGER -DUSE_STRERROR  -Dvsyslog=myvsyslog -DALWAYS_HOSTNAME -DHAVE_IPV6 -c hosts_access.c
hosts_access.c: In function ‘ipv6_mask’:
hosts_access.c:408:5: error: unknown type name ‘uchar_t’
hosts_access.c:408:19: error: ‘uchar_t’ undeclared (first use in this function)
hosts_access.c:408:19: note: each undeclared identifier is reported only once for each function it appears in
hosts_access.c:408:27: error: expected expression before ‘)’ token
hosts_access.c:419:27: error: expected expression before ‘)’ token

After fixing this small issue (replacing uchar_t with unsigned char) another issue presents itself:

misc.c:(.text+0x1e6): undefined reference to `freehostent'
misc.c:(.text+0x202): undefined reference to `getipnodebyname'
misc.c:(.text+0x22f): undefined reference to `freehostent'
misc.c:(.text+0x24b): undefined reference to `getipnodebyname'

These functions are (according to the manpage) deprecated and removed from glibc.
Comment 5 Viktor Hercinger 2013-01-31 09:32:36 UTC 
Created attachment 690801 [details]
Update to official IPv6 codebase

Attached a patch with the proposed changes. The patch uses the official codebase w/ IPv6 support. Both issues are solved in it.
Comment 6 Petr Lautrbach 2013-01-31 15:40:35 UTC 
Applied, thanks.
http://pkgs.fedoraproject.org/cgit/tcp_wrappers.git/commit/?id=cf076b1867b6310182b72007111dfb89612eedcf