Bug 699246

Summary: Empty MBR crashes liveusb-creator
Product: [Fedora] Fedora Reporter: Christoph Wickert <cwickert>
Component: liveusb-creatorAssignee: Luke Macken <lmacken>
Status: CLOSED WONTFIX QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 14CC: lmacken, pfrields
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-16 14:03:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Christoph Wickert 2011-04-24 15:22:45 UTC
Description of problem:
liveusb creator crashes when started with --reset-mbr but the MBR is of the target device empty.

Version-Release number of selected component (if applicable):
liveusb-creator-3.9.3-1.fc14.noarch

How reproducible:
always

Steps to Reproduce:
1. prepare a USB key with empty MBR e.g. by letting fdisk write a new empty partition table. Add a partition and format it, but make sure that there is no MBR.
2. # liveusb-creator --reset-mbr
3. press 'Create LiveUSB'
  
Actual results:
Log window:

Fedora-15-Beta-x86_64-Live-Desktop.iso selected
The Master Boot Record on your device is blank. Pressing 'Create LiveUSB' again will reset the MBR on this device.

Press 'Create LiveUSB' again

GUI freezes at 0%. Console output:
ERROR:dbus.connection:Unable to set arguments ([],) according to signature None: <type 'exceptions.ValueError'>: Unable to guess signature from an empty list
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/liveusb/gui.py", line 460, in begin
    self.live.unmount_device(force=True)
  File "/usr/lib/python2.7/site-packages/liveusb/creator.py", line 536, in unmount_device
    dbus_interface='org.freedesktop.Hal.Device.Volume')
  File "/usr/lib/python2.7/site-packages/dbus/proxies.py", line 140, in __call__
    **keywords)
  File "/usr/lib/python2.7/site-packages/dbus/connection.py", line 620, in call_blocking
    message.append(signature=signature, *args)
ValueError: Unable to guess signature from an empty list


Expected results:
As written in the log window, pressing the 'Create ...' button a second time should create a MBR on the stick.

Additional info:
Partition table of the USB key that was used:

# LANG=C fdisk -l /dev/sdb

Disk /dev/sdb: 2011 MB, 2011168768 bytes
54 heads, 54 sectors/track, 1347 cylinders, total 3928064 sectors
Units = sectors of 1 * 512 = 512 bytes
Sector size (logical/physical): 512 bytes / 512 bytes
I/O size (minimum/optimal): 512 bytes / 512 bytes
Disk identifier: 0x2a86323f

   Device Boot      Start         End      Blocks   Id  System
/dev/sdb1            2048     3928063     1963008    e  W95 FAT16 (LBA)

Comment 1 Christoph Wickert 2011-04-24 15:25:38 UTC
Actually it's not the --reset-mbr option, it also crashes without. Adjusting summary.

Comment 2 Fedora End Of Life 2012-08-16 14:03:11 UTC
This message is a notice that Fedora 14 is now at end of life. Fedora 
has stopped maintaining and issuing updates for Fedora 14. It is 
Fedora's policy to close all bug reports from releases that are no 
longer maintained.  At this time, all open bugs with a Fedora 'version'
of '14' have been closed as WONTFIX.

(Please note: Our normal process is to give advanced warning of this 
occurring, but we forgot to do that. A thousand apologies.)

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, feel free to reopen 
this bug and simply change the 'version' to a later Fedora version.

Bug Reporter: Thank you for reporting this issue and we are sorry that 
we were unable to fix it before Fedora 14 reached end of life. If you 
would still like to see this bug fixed and are able to reproduce it 
against a later version of Fedora, you are encouraged to click on 
"Clone This Bug" (top right of this page) and open it against that 
version of Fedora.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events.  Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

The process we are following is described here: 
http://fedoraproject.org/wiki/BugZappers/HouseKeeping