Bug 699275
| Summary: | Providing native systemd file for upcoming F15 Feature Systemd | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jóhann B. Guðmundsson <johannbg> | ||||||
| Component: | munin | Assignee: | Kevin Fenzi <kevin> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | drjohnson1, ingvar, kevin, kuijstej, lpoetter | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-06-16 02:14:16 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Jóhann B. Guðmundsson
2011-04-24 20:46:11 UTC
I do belive that this should be done in the package at install time not in the service mkdir -p /var/run/munin 2>/dev/null chown munin /var/run/munin To test this. Copy the file into /lib/systemd/system/ directory Run systemctl daemon-reload Then run systemctl start/stop/restart/enable/disable munin-node.service (In reply to comment #1) > I do belive that this should be done in the package at install time not in the > service > > mkdir -p /var/run/munin 2>/dev/null > chown munin /var/run/munin Unless I am missing something, /var/run is a tmpfs now... so the init script or systemd unit file would need to create it? The package can't or it would disappear after a reboot, right? Moving systemd service RFEs to rawhide. At this point, it is not appropriate in the Fedora 15 cycle to add these. Furthermore, at this point, we are still finalizing the packaging guidelines to handle SysV -> systemd upgrades. We therefore request: - wait until there are packaging guidelines (this will be announced on the devel list). This ensures that upgrades will work smoothly and we/you won't have to do multiple sets of changes. - work on these sorts of changes for Fedora 16 where necessary, not Fedora 15, as we're trying to fix things for release. - do *not* change a service from SysV to systemd in an existing release (such as Fedora 15), as this is the sort of behavior change that goes against our update policy, documented as https://fedoraproject.org/wiki/Updates_Policy Created attachment 495080 [details]
Native systemd service file with directory and ownership creation..
Real service create the dir from it's initialization code others need to result to this ;)
*** Bug 702871 has been marked as a duplicate of this bug. *** munin-1.4.5-9 has a native service file. Btw should not this part of the service file ExecStartPre=/bin/mkdir -p /var/run/munin ExecStartPre=/bin/chown munin /var/run/munin be moved into a tmpfile see http://fedoraproject.org/wiki/Packaging:Tmpfiles.d And please close bugs when FIXED ;) Added /etc/tmpfiles.d/munin.conf entry and changed version to F16. For users that already have F15 init.d script converting to systemd.service file is problematic, and FPC decided not to change this method mid-release. |