Bug 699805

Summary: Xorg 1.9 + nvidia binary drivers broken xrandr rotation
Product: [Fedora] Fedora Reporter: Richard Harman <redhat>
Component: xorg-x11-serverAssignee: X/OpenGL Maintenance List <xgl-maint>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: high Docs Contact:
Priority: unspecified    
Version: 14CC: mcepl, xgl-maint
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-04-26 23:27:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Revert "randr: check for virtual size limits before set crtc" none

Description Richard Harman 2011-04-26 16:18:13 UTC
Created attachment 494982 [details]
Revert "randr: check for virtual size limits before set crtc"

Description of problem:

An incorrect sanity check on values for rotation introduced in the 1.7 branch that made it into the 1.9 branch is causing rotation to fail.  The change that causes this issue was reverted in the 1.7 branch, but not the 1.9 branch that Fedora appears to be sourcing from.

    $ xrandr -o left
    X Error of failed request:  BadValue (integer parameter out of range for
operation)
      Major opcode of failed request:  154 (RANDR)
      Minor opcode of failed request:  2 (RRSetScreenConfig)
      Value in failed request:  0x780
      Serial number of failed request:  14
      Current serial number in output stream:  14


Version-Release number of selected component (if applicable):

Attached is a patch that reverts this change, that can be applied to the RPM directly:


Additional info:

http://cgit.freedesktop.org/xorg/xserver/commit/?id=d1107918
http://cgit.freedesktop.org/xorg/xserver/commit/?h=server-1.7-branch&id=d77ffa9
http://www.nvnews.net/vbulletin/showthread.php?p=2406364
https://bugs.freedesktop.org/show_bug.cgi?id=35399

Comment 1 Matěj Cepl 2011-04-26 23:27:01 UTC
We believe that it is more appropriate to let this bug be resolved upstream.

We will continue to track the issue in the centralized upstream bug tracker, and will review any bug fixes that become available for consideration in future updates.

Thank you for helping to make free software better.

Comment 2 Richard Harman 2011-04-27 03:08:47 UTC
Hm, actually it appears that this fix has been committed upstream.

http://cgit.freedesktop.org/xorg/xserver/commit/?h=server-1.9-branch&id=d77ffa918b2aaa3ca1deb17ed0145199d0f863da

What branch does fedora source from?

Comment 3 Matěj Cepl 2011-04-27 15:56:09 UTC
(In reply to comment #2)
> Hm, actually it appears that this fix has been committed upstream.
> 
> http://cgit.freedesktop.org/xorg/xserver/commit/?h=server-1.9-branch&id=d77ffa918b2aaa3ca1deb17ed0145199d0f863da
> 
> What branch does fedora source from?

http://koji.fedoraproject.org/koji/buildinfo?buildID=234454 is from 1.9 branch. What version of xorg-x11-server-Xorg package you have?

Thank you in advance

Comment 4 Richard Harman 2011-04-27 16:10:27 UTC
(In reply to comment #3)
> http://koji.fedoraproject.org/koji/buildinfo?buildID=234454 is from 1.9 branch.
> What version of xorg-x11-server-Xorg package you have?
> 
> Thank you in advance

I built this from xorg-x11-server-1.9.5-1.fc14.src.rpm, which was grabbed using yumdownloader --source xorg-x11-server on my fresh install fedora 14 box.

Comment 5 Matěj Cepl 2011-04-27 20:36:46 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > Hm, actually it appears that this fix has been committed upstream.
> > 
> > http://cgit.freedesktop.org/xorg/xserver/commit/?h=server-1.9-branch&id=d77ffa918b2aaa3ca1deb17ed0145199d0f863da
> > 

bradford:xserver (server-1.7-branch) $ git branch -a --contains \
    d77ffa918b2aaa3ca1deb17ed0145199d0f863da
  remotes/origin/server-1.7-branch
bradford:xserver (server-1.7-branch) $ 

However, I will follow the upstream bug, and if that get resolved (the bug still hasn't been closed), we will make sure it would come to Fedora as well.

Meanwhile, I have tried to apply the patch from this commit to our Xserver (http://koji.fedoraproject.org/koji/taskinfo?taskID=3031159). I have no idea whether it kills your first-born son or eats your homework, so use with caution and have your backups in order.