Bug 699815

Summary: Fix Coverity code maintainability issues
Product: [Retired] 389 Reporter: Nathan Kinder <nkinder>
Component: AdminAssignee: Nathan Kinder <nkinder>
Status: CLOSED CURRENTRELEASE QA Contact: Chandrasekar Kannan <ckannan>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.2.8CC: benl
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-17 14:08:50 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 434915    
Attachments:
Description Flags
Patch for cov#10859
nkinder: review?, rmeggins: review+
Patch for cov#10858
nkinder: review?, rmeggins: review+
Patch for cov#10849,10851
nhosoi: review+
Revised patch for cov#10849,10851 nhosoi: review+

Description Nathan Kinder 2011-04-26 16:40:59 UTC
A recent run of Coverity against the Admin Server code turned up a number of code maintainability issues.  We need to address these issues.

Comment 1 Nathan Kinder 2011-04-26 16:45:36 UTC
Created attachment 494992 [details]
Patch for cov#10859

Comment 2 Nathan Kinder 2011-04-26 16:58:51 UTC
Created attachment 494996 [details]
Patch for cov#10858

Comment 3 Nathan Kinder 2011-04-26 20:43:44 UTC
Created attachment 495036 [details]
Patch for cov#10849,10851

Comment 4 Nathan Kinder 2011-04-26 20:55:05 UTC
Created attachment 495037 [details]
Revised patch for cov#10849,10851

Comment 5 Nathan Kinder 2011-04-26 21:01:09 UTC
Pushed patches to master.  Thanks to Rich and Noriko for their reviews!

Counting objects: 23, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (15/15), done.
Writing objects: 100% (15/15), 1.62 KiB, done.
Total 15 (delta 12), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/admin.git
   99c91b3..0f9bcc0  master -> master