Bug 699857

Summary: RHEL6.1- System logging - pcieport 0000:00:nn.n: PCIe errors handled by OS
Product: Red Hat Enterprise Linux 6 Reporter: IBM Bug Proxy <bugproxy>
Component: kernelAssignee: Prarit Bhargava <prarit>
Status: CLOSED DUPLICATE QA Contact: Red Hat Kernel QE team <kernel-qe>
Severity: medium Docs Contact:
Priority: medium    
Version: 6.1CC: arozansk, balkov, jkachuck
Target Milestone: rc   
Target Release: ---   
Hardware: x86_64   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-15 12:34:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 684953    
Attachments:
Description Flags
hs22 blade logs
none
x3850/3950X5 logs none

Description IBM Bug Proxy 2011-04-26 19:01:10 UTC
Logs attached for a blade (HS22) and QPI scaled x3850/x3950 X5. Note that this is being 
logged for every slot in the system and on the scaled system...every slot in both chassis. No 
noticed detrimental effects. We would like to know if this is something new with 6.1. Tester 
has verified on the HS22 that these messages are not seen in 6.0. This has been noticed since 
RHEL 6.1 snapshot 3 through snapshot 5.

Example:
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:01.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:03.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:05.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:07.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:09.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:1c.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:00:1c.4: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:80:00.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:80:01.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:80:03.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:80:07.0: PCIe errors handled by OS.
Apr  7 11:04:45 localhost kernel: pcieport 0000:80:09.0: PCIe errors handled by OS.

The messages are logged from this section of code in pcie_port_acpi_setup() from 
drivers/pci/pcie/portdrv_acpi.c


        if (pci_aer_available()) {
                if (aer_acpi_firmware_first()) {
                        dev_info(&port->dev, "PCIe errors handled by BIOS.\n");
                 } else {
                        flags |= OSC_PCI_EXPRESS_AER_CONTROL;
                        dev_info(&port->dev, "PCIe errors handled by OS.\n");
                }
        }

The above varies slightly from the mainline source in that mainline uses dev_dbg() as opposed 
to dev_info() and it does not have the

dev_info(&port->dev, "PCIe errors handled by OS.\n");

which is what we are seeing as each pcie port is set up. Based on the changelog the ACPI 
related support may have been introduced around 2.6.32-108.el6 but I don't have access to 
the RH bugzilla bug to know for sure.

> I don't think that in general we want "informational" messages such as these
> logged. They imply hardware errors the way they are worded. Really, how are you
> ever going to convince a customer they need or require a vendor firmware or
> driver update for an adapter when the OS is blatantly logging a message telling
> them every single slot in your system has had an error?

I guess it's a difference in perception. When I read the message, I simply read it as PCIe errors 
will be handled by the OS (as opposed to BIOS or FW) but I agree this message should be 
improved for readability as it could be misinterpreted and possibly reverted to a debug 
message (like in mainline) as it doesn't seem that critical to inform the user about this detail.
      
1. Server architecture(s) (please list all effected) (x86/POWER6/Z/etc.): x86
2. Server type (9117-MMA/HS20/s390/etc.): x3850/3950X5
3. Other components involved (ixgbe/java/emulex/etc.): kernel
4. Does the server have the latest GA firmware? Yes
5. Has the problem been shown to occur on more than one system? Yes
6. What is the latest official distro build on which this bug has been seen? RHEL 6.1 SS5

Comment 1 IBM Bug Proxy 2011-04-26 19:01:24 UTC
Created attachment 495013 [details]
hs22 blade logs

Comment 2 IBM Bug Proxy 2011-04-26 19:01:27 UTC
Created attachment 495014 [details]
x3850/3950X5 logs

Comment 4 Prarit Bhargava 2011-05-09 12:55:42 UTC
Sent a trivial patch upstream here.  Please note the OS message no longer occurs upstream but we can fix that too...

http://marc.info/?l=linux-acpi&m=130494547606416&w=2

P.

Comment 5 Prarit Bhargava 2011-06-15 12:34:05 UTC

*** This bug has been marked as a duplicate of bug 710291 ***