| Summary: | Review Request: perl-Authen-CAS-Client - Interface for authentication via JA-SIG's Central Authentication Service | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nicholas van Oudtshoorn <vanoudt> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, iarnell, notting, panemade |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Authen-CAS-Client-0.05-2.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-01-02 21:49:31 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Nicholas van Oudtshoorn
2011-04-28 07:51:56 UTC
Nicholas has a sponsor - no need to block FE-NEEDSPONSOR any more. Nicholas,
its been some time since this package has been added for review. Are you around? If you want me to review then I can start reviewing this package.
Hi Parag, Yes - I'm still around! (Although the priority of this isn't huge - just chipping away at getting the dependencies for Koha ILS packaged one of these years). If you feel up for a review - go for it! Suggestions: 1) If building this on Fedora only then you don't need a) buidlroot b) cleaning of buildroot in %install c) %clean section d) defattr(-,root,root,-) 2) yum should install dependencies automatically so you don't need to specify Requires: 3) Changelogs should use http://fedoraproject.org/wiki/PackagingGuidelines#Changelogs ping any updates here? Thanks for the PING - got busy over here. Have updated a new SPEC file and SRPM: Spec URL: http://dl.dropbox.com/u/8648526/packaging/perl-Authen-CAS-Client.spec SRPM URL: http://dl.dropbox.com/u/8648526/packaging/perl-Authen-CAS-Client-0.05-2.fc16.src.rpm Review:- + koji scratch build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=3545434 + rpmlint on rpms gave 2 packages and 0 specfiles checked; 0 errors, 0 warnings. + source verified with upstream as (sha1sum) fb13f4789a49df20769a27474b2e9174237b4d15 Authen-CAS-Client-0.05.tar.gz fb13f4789a49df20769a27474b2e9174237b4d15 ../SOURCES/Authen-CAS-Client-0.05.tar.gz + make test gave All tests successful. Files=6, Tests=204, 1 wallclock secs ( 0.05 usr 0.01 sys + 0.47 cusr 0.05 csys = 0.58 CPU) + Package: perl-Authen-CAS-Client-0.05-2.fc17.noarch Provides: perl(Authen::CAS::Client) = 0.05 perl(Authen::CAS::Client::Response) = 0.03 perl(Authen::CAS::Client::Response::AuthFailure) perl(Authen::CAS::Client::Response::AuthSuccess) perl(Authen::CAS::Client::Response::Error) perl(Authen::CAS::Client::Response::Failure) perl(Authen::CAS::Client::Response::ProxyFailure) perl(Authen::CAS::Client::Response::ProxySuccess) perl(Authen::CAS::Client::Response::Success) Requires: perl >= 0:5.006_001 perl(Authen::CAS::Client::Response) perl(Authen::CAS::Client::Response::Failure) perl(Authen::CAS::Client::Response::Success) perl(LWP::UserAgent) perl(URI) perl(URI::QueryParam) perl(XML::LibXML) perl(base) perl(strict) perl(warnings) + rest follows packaging guidelines Suggestions: 1) you don't need following in spec BuildRequires: perl >= 1:5.6.1 2) Remove ">=0.00" from all the BuildRequires: lines. you don't need them. APPROVED. Please include an SCM request. New Package SCM Request ======================= Package Name: perl-Authen-CAS-Client Short Description: Interface for authentication via JA-SIG's Central Authentication Service Owners: vanoudt Branches: f15 f16 InitialCC: perl-sig Git done (by process-git-requests). Can you build the package? Built, and should be in updates-testing perl-Authen-CAS-Client-0.05-2.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/perl-Authen-CAS-Client-0.05-2.fc16 perl-Authen-CAS-Client-0.05-2.fc16 has been pushed to the Fedora 16 testing repository. perl-Authen-CAS-Client-0.05-2.fc16 has been pushed to the Fedora 16 stable repository. |