Bug 700532

Summary: Incorrect if condition in dsalib
Product: [Retired] 389 Reporter: Nathan Kinder <nkinder>
Component: AdminAssignee: Nathan Kinder <nkinder>
Status: CLOSED CURRENTRELEASE QA Contact: Viktor Ashirov <vashirov>
Severity: unspecified Docs Contact:
Priority: medium    
Version: 1.2.8CC: rmeggins
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-12-07 16:52:08 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 434915    
Attachments:
Description Flags
Patch for cov#10832 nhosoi: review+

Description Nathan Kinder 2011-04-28 15:31:48 UTC
The dsalib code has an incorrect if condition in ds_get_file_list().  It looks like the condition at line 114/115 should be checking if the realloc failed so we can avoid filling in ret if we were unable to allocate memory.

Comment 1 Nathan Kinder 2011-04-28 15:33:49 UTC
Created attachment 495579 [details]
Patch for cov#10832

Comment 2 Nathan Kinder 2011-04-28 18:07:01 UTC
Pushed patch to master.  Thanks to Noriko for her review!

Counting objects: 9, done.
Delta compression using up to 2 threads.
Compressing objects: 100% (5/5), done.
Writing objects: 100% (5/5), 686 bytes, done.
Total 5 (delta 3), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/admin.git
   0a28e3d..9047b26  master -> master

Comment 5 Rich Megginson 2011-06-06 21:40:00 UTC
coverity is clean - marking verified