Bug 700608
Summary: | barfs on spaces in file names | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Bill Nottingham <notting> |
Component: | augeas | Assignee: | David Lutterkort <lutter> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 15 | CC: | apevec, hbrock, laine, lutter, mbooth, rvokal |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | augeas-0.8.1-2.el5 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-05-09 03:59:11 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Bill Nottingham
2011-04-28 19:12:02 UTC
When you do "lsof | grep libvirtd" do you see a lot of .aug files? (more than 1 is enough to verify my suspicion). What is the version of augeas? Is it maybe earlier than 0.8.1-1.fc15? I'm betting that this is the same as Bug 690286 in RHEL, which was fixed in augeas-0.8.1-1.fc15. If you're not running that version, please update and retest. I'm moving the component to augeas, anticipating that's the problem. ugh. I really should pay attention to the details - you've already told me you're using the latest augeas. Nevermind. I'll look into it. The issue is that spaces in the paths need to be escaped (by netcf) with a backslash, i.e. instead of talking about "/files/etc/sysconfig/network-scripts/ifcfg-foo bar" it needs to "/files/etc/sysconfig/network-scripts/ifcfg-foo\ bar" IOW, netcf needs to do the equivalent of 's@ @\ @g' on all paths - I am wondering if I should try and catch this at the augeas level, with some sort of flag to aug_init. Bill: where do these ifcfg files with spaces in them come from ? (In reply to comment #3) > IOW, netcf needs to do the equivalent of 's@ @\ @g' on all paths - I am > wondering if I should try and catch this at the augeas level, with some sort of > flag to aug_init. My opinion is that, since the string being passed into augeas is just a path, and space has no special meaning, the caller shouldn't be required to escape it - the space is unambiguously just a space embedded in the path, not a separator between arguments, etc. (but of course I'll deal with whatever you decide to do :-) Why would you need a flag to aug_init? Is there any reasonable circumstance when the application would *not* want a space embedded in a path to be escaped as needed within augeas? (In reply to comment #3) > Bill: where do these ifcfg files with spaces in them come from ? NetworkManager migrating connections from GConf to system connections. It appears if it has multiple configured connections for a given SSID (in this case), it will write the second one with " 1" appended to the file name. There's nothing specifically in initscripts or NM that forbids spaces in the file name, to my knowledge (although obviously it's not common, and there might be a lingering bug or two somewhere with it.) Committed a fix for this upstream as commit ea010d85. Path expressions can now contain whitespace _inside_ each file name - file names that start or end with whitespace still require that the space is escaped with '\'; but nobody does this anyway, right ? augeas-0.8.1-2.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/augeas-0.8.1-2.el5 augeas-0.8.1-2.el4 has been submitted as an update for Fedora EPEL 4. https://admin.fedoraproject.org/updates/augeas-0.8.1-2.el4 augeas-0.8.1-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/augeas-0.8.1-2.fc15 augeas-0.8.1-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/augeas-0.8.1-2.fc14 augeas-0.8.1-2.fc13 has been submitted as an update for Fedora 13. https://admin.fedoraproject.org/updates/augeas-0.8.1-2.fc13 Package augeas-0.8.1-2.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing augeas-0.8.1-2.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/augeas-0.8.1-2.fc15 then log in and leave karma (feedback). augeas-0.8.1-2.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. augeas-0.8.1-2.fc14 has been pushed to the Fedora 14 stable repository. If problems still persist, please make note of it in this bug report. augeas-0.8.1-2.fc13 has been pushed to the Fedora 13 stable repository. If problems still persist, please make note of it in this bug report. augeas-0.8.1-2.el4 has been pushed to the Fedora EPEL 4 stable repository. If problems still persist, please make note of it in this bug report. augeas-0.8.1-2.el5 has been pushed to the Fedora EPEL 5 stable repository. If problems still persist, please make note of it in this bug report. |