Bug 700632

Summary:	qpid-java-common rpm erroneously includes qpid-ra-0.10.jar
Product:	Red Hat Enterprise MRG	Reporter:	Andrew Stitcher <astitcher>
Component:	qpid-java	Assignee:	Andrew Stitcher <astitcher>
Status:	CLOSED ERRATA	QA Contact:	ppecka <ppecka>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	2.0	CC:	iboverma, jneedle, jross, ppecka, rattapat+nobody
Target Milestone:	2.1.2
Target Release:	---
Hardware:	Unspecified
OS:	Linux
Whiteboard:
Fixed In Version:	qpid-java-0.14-1.el5	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-04-30 17:53:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	783492

Description Andrew Stitcher 2011-04-28 20:46:42 UTC

Description of problem:

Due to an oversight in the rpm spec file qpid-ra-0.10.jar is being picked up from the build/lib directory and installed into the qpid-deps directory as if it was an external jar that the qpid jars depend on. It isn't.

How reproducible:
Always.

Steps to Reproduce:
1. install qpid-java-common-0.10-4.el5.noarch.rpm
  
Actual results:

/usr/share/java/qpid-deps/qpid-ra-0.10.jar is installed

Expected results:

This jar is never expected to be installed

Comment 1 Andrew Stitcher 2011-04-28 20:50:24 UTC

The fix for this is a pretty simple fix to the spec file, which is very low risk.

Even though this really isn't in itself a blocking issue it could be confusing. I'd like to get this in if we do respin due to fixing any other problems.

Comment 2 Andrew Stitcher 2011-04-28 21:03:22 UTC

Suggested fix:

cvs diff: Diffing .
Index: qpid-java.spec
===================================================================
RCS file: /cvs/dist/rpms/qpid-java/RHEL-5-MRG/qpid-java.spec,v
retrieving revision 1.126
diff -r1.126 qpid-java.spec
3c3
< Release: 	4%{?dist}
---
> Release: 	5%{?dist}
109,110c109,110
< install -p -m 755 $(find build/lib/ -name '*.jar' \
<   ! -name 'qpid-client*.jar' ! -name 'qpid-common*.jar') %{buildroot}%{_javadir}/qpid-deps
---
> install -p -m 755 build/lib/qpid-deps*.jar %{buildroot}%{_javadir}/qpid-deps
> install -p -m 755 build/lib/log4j-slf4j.jar %{buildroot}%{_javadir}/qpid-deps
154a155,157
> * Wed Apr 20 2011 Andrew Stitcher <astitcher> - 0:0.10.-5
> - Removed jar file that was not meant to be in qpid-java-common
>

Comment 3 Jeff Needle 2011-04-28 22:32:34 UTC

Sounds reasonable to me.  Giving it the QA blessing.

Comment 4 Andrew Stitcher 2011-05-13 03:43:56 UTC

This is now checked into the specfile and should happen from 0.10-5 onwards

Comment 6 ppecka 2012-01-16 14:52:39 UTC

VERIFIED on rhel5 / rhel6 , i686 / x86_64:

qpid-java-common-0.14-1.el6.noarch
qpid-java-common-0.14-1.el5

Comment 7 errata-xmlrpc 2012-04-30 17:53:41 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHSA-2012-0529.html