Bug 700670

A little more detailed logic to allow for topics in Draft state, and topics that are marked as written, but can't be located at build time (see the referenced error message for a list of probably causes for that scenario):

ref: https://svn.devel.redhat.com/repos/ecs/TopicRepository/Skynet_System_Messages/

Here's the logic as pseudo-code.

While building:

if Topic.WRITTEN
  try
     topictouse = retrieve(Topic.SVNURL)
     use topictouse
  fail
     use Topic.Title;Topic.Descr
     inject Topic_Repository/Skynet_System_Messages/Missing_Topic_Notice.xml after tag[section.title]
  end:try

if not Topic.WRITTEN
  try
    topictouse = retrieve(Topic.SVNURL)
    use topictouse
    inject Topic_Repository/Skynet_System_Messages/Draft_Notice.xml after tag[section.title]
  fail
    use Topic.Title;Topic.Descr
  end:try

Done.

If the topic is flagged as not written:
 Check if it has an SVNURL. If it does, we can assume it is in draft state.
 If an SVNURL is set:
   Try to download the topic from the SVNURL. 
   If downloading the topic from the SVNURL fails:
     Use the Topic Title and Description, along with the "Missing Topic" error message [1] and "Draft topic" message [2].
     Write an error to the error list.
   If downloading the topic from the SVNURL succeeds: 
      Validate the topic.
      If the topic validates:
         Use the topic, with the "Draft topic" message [2] inserted.
      If the topic does not validate: 
         Use the "Topic fails validation message" error message [3] and "Draft topic" message [2].
         Write an error to the error list
  If no SVNURL is set:
    Use the Topic.Title and Topic.Descr along with the "Topic Not Written" message [4].

If the topic is flagged as written:
  Check if it has an SVNURL. 
  If it does not have an SVNURL: 
    Use the Topic Title and Description, along with the "Missing Topic" error message [1]
  If it does have an SVNURL:
    Try to download the topic from the SVNURL.
    If downloading the topic from the SVNURL fails:
      Use the Topic Title and Description, along with the "Missing Topic" error message [1]
    If downloading the topic from the SVNURL succeeds:
      Validate the topic.
      If the topic validates:
         Use the topic.
      If the topic does not validate: 
         Use the "Topic fails validation message" error message [3].
         Write an error to the error list.      

[1] https://svn.devel.redhat.com/repos/ecs/TopicRepository/Skynet_System_Messages/Missing_Topic_Notice.xml
[2] https://svn.devel.redhat.com/repos/ecs/TopicRepository/Skynet_System_Messages/Draft_Notice.xml
[3] https://svn.devel.redhat.com/repos/ecs/TopicRepository/Skynet_System_Messages/Topic_Fails_Validation.xml
[4] https://svn.devel.redhat.com/repos/ecs/TopicRepository/Skynet_System_Messages/Topic_Not_Written.xml

Update: whenever the "Missing Topic" message is used, just use the Topic.Title. Don't include the Topic.Descr.

We want to make it clear that something is wrong.

Topics with missing svn repo urls and those that link to docbook that failed validation have a note and a warning. This makes it obvious that something is wrong.

Regression. 

The latest Docbook build contains only topics which have a TopicSNVURL. An attempt to build the whole release (a query that returns 1000+ topics) results in a Docbook output with only ~60 topics in, and tons of compiler error messages that suggest that all topics with SVNURL were not included.


The idea of building the release with all topics, including unwritten ones, is to produce a "wire-frame model" of the release for information architecture preview.

fixed.