| Summary: | Review Request: liblogging - An easy to use, portable, open source library for system logging | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Jeffrey C. Ollie <jeff> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, mario.blaettermann, notting |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-07-20 21:14:10 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Jeffrey C. Ollie
2011-04-29 14:37:25 UTC
The link to the source rpm seems to be broken. Oops, sorry: SRPM URL: http://jcollie.fedorapeople.org/liblogging-0.7.1-1.fc14.src.rpm Instead of using
%{__sed} -i 's/\r//' COPYING
%{__sed} -i 's/\r//' AUTHORS
%{__sed} -i 's/\r//' ChangeLog
%{__sed} -i 's/\r//' README
to convert EOLs, please use e.g.
for file in COPYING AUTHORS ChangeLog README; do
sed -i 's/\r//' $file > $file.new && \
touch -r $file $file.new && \
mv $file.new $file
done
which preserves time stamps.
(In reply to comment #3) > Instead of using > %{__sed} -i 's/\r//' COPYING > %{__sed} -i 's/\r//' AUTHORS > %{__sed} -i 's/\r//' ChangeLog > %{__sed} -i 's/\r//' README > to convert EOLs, please use e.g. > for file in COPYING AUTHORS ChangeLog README; do > sed -i 's/\r//' $file > $file.new && \ > touch -r $file $file.new && \ > mv $file.new $file > done > which preserves time stamps. Fixed. Spec URL: http://jcollie.fedorapeople.org/liblogging.spec SRPM URL: http://jcollie.fedorapeople.org/liblogging-0.7.1-2.src.rpm The SRPM link is broken again. Would be useful for a Koji scratch build. OOPS, sorry again. That's what I get for staying up late to watch the news... http://jcollie.fedorapeople.org/liblogging-0.7.1-2.fc14.src.rpm Scratch build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3045757 $ rpmlint -v * liblogging.i686: I: checking liblogging.i686: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan liblogging.i686: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging.src: I: checking liblogging.src: W: spelling-error %description -l en_US syslog -> dyslogia, systole, slogan liblogging.src: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging.src: I: checking-url http://download.rsyslog.com/liblogging/liblogging-0.7.1.tar.gz (timeout 10 seconds) liblogging-debuginfo.i686: I: checking liblogging-debuginfo.i686: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging-devel.i686: I: checking liblogging-devel.i686: I: checking-url http://www.liblogging.org/ (timeout 10 seconds) liblogging.spec: I: checking-url http://download.rsyslog.com/liblogging/liblogging-0.7.1.tar.gz (timeout 10 seconds) 4 packages and 1 specfiles checked; 0 errors, 2 warnings. Besides the spelling errors, no further issues from rpmlint. The docs in the -devel package are originally in a "html" subfolder. In my mind, it would be useful to don't mix the html stuff with the docs from the base package (AUTHORS etc.), keeping this subfolder in %{docdir}%{name}%{version}. Any interest to keep this review request alive? Otherwise, we should close this bug for the time being. I have no real interest in it anymore... |