| Summary: | fix missing string in usage output of liveimage-mount | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Chris Marcantonio <cmarcant> |
| Component: | livecd-tools | Assignee: | Brian Lane <bcl> |
| Status: | CLOSED UPSTREAM | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | low | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 15 | CC: | adam.stokes, bcl, bruno, dhuff, Jasper.Hartline, katzj |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-05-03 17:55:29 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
This has been changed on master with the addition of a bunch of new options. |
Description of problem: The usage statement of liveimage-mount is missing a string in it's print statement, causing the default output to read: sh-4.2$ liveimage-mount Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS] sh-4.2$ This is of course a strictly cosmetic bug, and doesn't have any impact on the actual function of the tool. Version-Release number of selected component (if applicable): livecd-tools-15.6-1.fc15.i686 How reproducible: Every time. Steps to Reproduce: 1. install latest version of livecd-tools 2. run liveimage-mount in a fashion that generates a usage statement Actual results: Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS] Expected results: Usage: /usr/bin/liveimage-mount ISO.iso MOUNTPOINT [COMMAND] [ARGS] Additional info: Pretty simple one line patch to add the variable to the end of the print statement: sh-4.2# diff liveimage-mount liveimage-mount.ORIG 28c28 < print "Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS]" % sys.argv[0] --- > print "Usage: %s ISO.iso MOUNTPOINT [COMMAND] [ARGS]" sh-4.2# Is sys.argv[0] acceptable here, or is it preferred to strip the path off the front of the filename first?