Bug 701184

Summary: Review Request: perl-CGI-Application-Plugin-RequireSSL - Force SSL in specified pages or modules
Product: [Fedora] Fedora Reporter: Emmanuel Seyman <emmanuel>
Component: Package ReviewAssignee: Marcela Mašláňová <mmaslano>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: mmaslano: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-25 02:24:01 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Emmanuel Seyman 2011-05-01 22:15:43 UTC
Spec URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-RequireSSL/perl-CGI-Application-Plugin-RequireSSL.spec
SRPM URL: http://people.parinux.org/~seyman/fedora/perl-CGI-Application-Plugin-RequireSSL/perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc14.src.rpm
Description:
CGI::Application::Plugin::RequireSSL allows individual run modes or whole
modules to be protected by SSL. If a standard HTTP request is received, you
can specify whether an error is raised or if the request should be
redirected to the HTTPS equivalent URL.

Comment 1 Marcela Mašláňová 2011-05-11 11:14:56 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=3065771
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides ~/Downloads/perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc15.noarch.rpm 
perl(CGI::Application::Plugin::RequireSSL) = 0.04
perl-CGI-Application-Plugin-RequireSSL = 0.04-1.fc15
rpm -qp --requires ~/Downloads/perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc15.noarch.rpm 
perl(:MODULE_COMPAT_5.12.3)  
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(CompressedFileNames) <= 3.0.4-1
perl(Attribute::Handlers)  
perl(base)
perl(Carp)                                                                   
perl(Data::Dumper)
perl(Exporter)                                                               
perl(strict)                                                                 
perl(warnings)
rpmlib(PayloadIsXz) <= 5.2-1

Note: rm -rf and deffattr are not needed any more.

APPROVED

Comment 2 Emmanuel Seyman 2011-05-12 05:06:12 UTC
Thank you, Marcela. Requesting SCM.

New Package SCM Request
=======================
Package Name: perl-CGI-Application-Plugin-RequireSSL
Short Description: Force SSL in specified pages or modules
Owners: eseyman
Branches: f13 f14 f15
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-05-12 16:39:18 UTC
Git done (by process-git-requests).

Comment 4 Fedora Update System 2011-05-12 20:58:23 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc14

Comment 5 Fedora Update System 2011-05-12 20:58:30 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc15

Comment 6 Fedora Update System 2011-05-12 20:58:37 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc13 has been submitted as an update for Fedora 13.
https://admin.fedoraproject.org/updates/perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc13

Comment 7 Fedora Update System 2011-05-13 23:04:18 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc13 has been pushed to the Fedora 13 testing repository.

Comment 8 Fedora Update System 2011-05-25 02:23:56 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc13 has been pushed to the Fedora 13 stable repository.

Comment 9 Fedora Update System 2011-05-25 02:32:06 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc14 has been pushed to the Fedora 14 stable repository.

Comment 10 Fedora Update System 2011-05-25 02:49:09 UTC
perl-CGI-Application-Plugin-RequireSSL-0.04-1.fc15 has been pushed to the Fedora 15 stable repository.