Bug 701241

Summary: improve README.Fedora
Product: [Fedora] Fedora Reporter: Moritz Barsnick <moritz>
Component: snoopyAssignee: Steve Traylen <steve.traylen>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: barsnick, steve.traylen
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-02 11:45:07 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
patch to transform README.Fedora to README.Fedora.in and replace the lib path at build time, plus syntax clarification none

Description Moritz Barsnick 2011-05-02 09:12:53 UTC
Description of problem:
README.Fedora contains an incorrect and not sufficiently clear example.

Version-Release number of selected component (if applicable):
1.7.10-2

How reproducible:
always

Steps to Reproduce:
1. read README.Fedora
2.
3.
  
Actual results:
set LD_PRELOAD=/lib64/snoopy.so

Expected results:
In a 32-bit package:
export LD_PRELOAD=/lib/snoopy.so
or
setenv LD_PRELOAD /lib/snoopy.so

Additional info:
I have a patch to make the README.Fedora a README.Fedora.in, and have the path replaced at build time. I'm not sure if this is okay on multi-arch (i.e. if you install 32-bit and 64-bit snoopy packages in parallel.

Comment 1 barsnick 2011-05-02 09:39:50 UTC
Created attachment 496199 [details]
patch to transform README.Fedora to README.Fedora.in and replace the lib path at build time, plus syntax clarification

(Different account of mine this time where e-mail doesn't bounce. Sorry.)

This is a Git-style patch (including a rename!) from my hg demonstrating my changes.

It renames README.Fedora to README.Fedora.in and adds a command in the SPEC which transforms the named path to the correct on for the build arch. Not sure if this would be correct in multi-arch environment, and the README.Fedora should just contain a hint instead.

Note also that 1.8.0 is released. :)

Comment 2 barsnick 2011-05-02 09:40:45 UTC
(Adding my other account to Cc:, I didn't get that checkbox when attaching a patch.)

Comment 3 Steve Traylen 2011-05-02 09:54:04 UTC
Hi,

Thanks, I'll incorporate this , there's another architecture independent way of doing it as well.



$ cat /etc/ld.so.preload 
/$LIB/snoopy.so

and it's evaluated at runtime. This is intact what I am using now and has the advantage
that it works for 32 bit binaries on a 64 bit system.

I'll merge your comments and this improvement.

Steve.

Comment 4 barsnick 2011-05-04 21:49:34 UTC
Very nice solution. Even I did not know that about the verbatim $LIB.

Thank you!