Bug 701494
Summary: | Review Request: wlmproxy - An advanced proxy for the MSN Messenger protocol | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | William Lima <wlima> | ||||
Component: | Package Review | Assignee: | Timur Kristóf <timur.kristof> | ||||
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-package-review, notting | ||||
Target Milestone: | --- | Flags: | timur.kristof:
fedora-review+
j: fedora-cvs+ |
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Whiteboard: | |||||||
Fixed In Version: | wlmproxy-0.1.3-0.1.20110521git67984d2.fc15 | Doc Type: | Bug Fix | ||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2011-05-17 01:01:27 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Attachments: |
|
Description
William Lima
2011-05-03 01:40:39 UTC
I'll review this package. There are only two things that I find to be not according to the Review Guidelines: - The MD5 of the tarball from Git and the tarball in the .src.rpm don't match - Please use %{_localstatedir} in the .spec file instead of "/var" I'll attach my detailed review which contains all items from the Review Guidelines. Created attachment 496669 [details] Checklist of the package, according to https://fedoraproject.org/wiki/Packaging:ReviewGuidelines latest package files Spec URL: http://poetinha.fedorapeople.org/wlmproxy.spec SRPM URL: http://poetinha.fedorapeople.org/wlmproxy-0.1.2-2.fc15.src.rpm I see that you've fixed the problems I found. - 'gzip -n' fixed the md5sum issue - You've fixed the scriptlet issue - As I see it, the rpmlint "E" error for wlmproxy.conf is intentional. I've also tested the package with a simple usecase and it appears to be working properly. I see no further obstacles for this package. The package is now APPROVED. Congratulations! :) New Package SCM Request ======================= Package Name: wlmproxy Short Description: An advanced proxy for the MSN Messenger protocol Owners: poetinha Branches: f14 f15 el6 InitialCC: Git done (by process-git-requests). wlmproxy-0.1.2-2.fc14 has been submitted as an update for Fedora 14. https://admin.fedoraproject.org/updates/wlmproxy-0.1.2-2.fc14 wlmproxy-0.1.2-2.fc14 has been pushed to the Fedora 14 testing repository. wlmproxy-0.1.2-2.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/wlmproxy-0.1.2-2.el6 wlmproxy-0.1.2-2.fc14 has been pushed to the Fedora 14 stable repository. wlmproxy-0.1.3-0.1.20110521git67984d2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/wlmproxy-0.1.3-0.1.20110521git67984d2.fc15 wlmproxy-0.1.2-2.el6 has been pushed to the Fedora EPEL 6 stable repository. wlmproxy-0.1.3-0.1.20110521git67984d2.fc15 has been pushed to the Fedora 15 stable repository. |