Bug 701683

Summary: Incorrect Requires - I think
Product: [Fedora] Fedora Reporter: David Riches <david.r>
Component: supybot-kojiAssignee: Jon Stanley <jonstanley>
Status: CLOSED NOTABUG QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: david.r, elad, jonstanley
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-16 23:57:27 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description David Riches 2011-05-03 14:48:51 UTC
Description of problem:

supybot-koji requires koji to be installed as a dependency, I don't think this is correct and koji doesn't need to be on the local machine. If this is the case, I'm happy to change the specs, build and update :-)

Version-Release number of selected component (if applicable):

latest

Comment 1 Elad Alfassa 2011-05-03 15:07:20 UTC
Yum would explain it better than me:
[elad@elephant ~]$ yum info koji
Loaded plugins: langpacks, presto, refresh-packagekit
Installed Packages
Name        : koji
Arch        : noarch
Version     : 1.6.0
Release     : 2.fc15
Size        : 797 k
Repo        : installed
From repo   : fedora
Summary     : Build system tools
URL         : http://fedorahosted.org/koji
License     : LGPLv2 and GPLv2+
Description : Koji is a system for building and tracking RPMS.  The base package
            : contains shared libraries and the command-line interface.

In other words, it's the client software for querying koji.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 2 David Riches 2011-05-03 15:12:51 UTC
Perhaps yum would explain it better still:


[david@vmserver supybot-koji]$ yum deplist supybot-koji
Loaded plugins: downloadonly, tmprepo
rpmfusion-free-updates                                                                                 | 3.3 kB     00:00     
rpmfusion-nonfree-updates                                                                              | 3.3 kB     00:00     
updates/metalink                                                                                       |  25 kB     00:00     
Finding dependencies: 
package: supybot-koji.noarch 0.1-5.fc12
  dependency: python(abi) = 2.6
   provider: python.i686 2.6.4-25.fc13
   provider: python.i686 2.6.4-27.fc13
  dependency: koji
   provider: koji.noarch 1.3.2-1.fc13
   provider: koji.noarch 1.6.0-1.fc13
  dependency: supybot
   provider: supybot.noarch 0.83.4.1-2.fc12
   provider: supybot.noarch 0.83.4.1-3.fc13


Note the dependency "koji" ;-) re-opening, is a bug

Comment 3 Elad Alfassa 2011-05-03 15:30:14 UTC
I do not see why do you think it's a bug. The package named koji contains the command line client for our build system, not the build system itself.



-- 
Fedora Bugzappers volunteer triage team
https://fedoraproject.org/wiki/BugZappers

Comment 4 Jon Stanley 2011-05-16 21:06:09 UTC
Hmm, I'll have to look at the source tonight. I think that you might be right, it may only call the http/xmlrpc interface to koji and not use the cli itself. Added to my TODO list :)

Comment 5 Jon Stanley 2011-05-16 23:57:27 UTC
While we don't use the koji CLI per se in the plugin, we do use the python libraries provided by the koji package to interact with it..

        self.koji_client = koji.ClientSession(koji_server, {})

and then we do stuff with koji_client. So I'm afraid that the Requires has to remain.

Comment 6 Jon Stanley 2011-05-17 00:00:09 UTC
Also, as Elad correctly points out, all that's required is the koji client pieces, not anything server-related.