Bug 702018
| Summary: | Review Request: python-easygui - Very simple, very easy GUI programming in Python | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Gwyn Ciesla <gwync> |
| Component: | Package Review | Assignee: | Matthias Runge <mrunge> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, mrunge, notting, wlima |
| Target Milestone: | --- | Flags: | mrunge:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | python-easygui-0.96-1.fc16 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-10-09 06:55:23 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Gwyn Ciesla
2011-05-04 14:41:23 UTC
Please fix your Review Summary. Review Summary? And fix how? I'm not sure what you mean. http://fedoraproject.org/wiki/Join_the_package_collection_maintainers#Create_Your_Review_Request * Make sure that you put the name of the package (excluding version and release numbers) in the 'Review Summary' field, along with a very brief summary of what the package is. http://fedoraproject.org/wiki/File:PackageReviewProcess_review.png <headdesk> I've been doing this quite awhile, and should know better. In my defense, this was submitted pre-coffee. Thank you, and good catch. :) Jon, there are two small issues, I just discovered.
rpmlint ./python-easygui.spec
./python-easygui.spec: E: specfile-error sh: line 0: fg: no job control
0 packages and 1 specfiles checked; 1 errors, 0 warnings.
rpmbuild -ba reports
RPM build errors:
Installed (but unpackaged) file(s) found:
/usr/lib/python3.2/site-packages/__pycache__/easygui.cpython-32.pyc
/usr/lib/python3.2/site-packages/__pycache__/easygui.cpython-32.pyo
Can you fix those, please?
Fixed, thanks! SPEC: http://zanoni.jcomserv.net/fedora/python-easygui/python-easygui.spec SRPM: http://zanoni.jcomserv.net/fedora/python-easygui/python-easygui-0.96-0.fc14.src.rpm You meant: http://zanoni.jcomserv.net/fedora/python-easygui/python-easygui-0.96-1.fc15.src.rpm Package Review ============== Key: - = N/A x = Check ! = Problem ? = Not evaluated === REQUIRED ITEMS === [x] Package is named according to the Package Naming Guidelines. [x] Spec file name must match the base package %{name}, in the format %{name}.spec. [x] Package meets the Packaging Guidelines. [x] Package successfully compiles and builds into binary rpms on at least one supported architecture. Tested on: koji, f16 http://koji.fedoraproject.org/koji/taskinfo?taskID=3386103 [x] Rpmlint output: [mrunge@sofja SPECS]$ rpmlint ./python-easygui.spec ../RPMS/noarch/python-easygui-0.96-1.fc16.noarch.rpm ../RPMS/noarch/python3-easygui-0.96-1.fc16.noarch.rpm ../SRPMS/python-easygui-0.96-1.fc16.src.rpm python-easygui.noarch: W: spelling-error %description -l en_US dialogs -> dialog, dialog s python-easygui.noarch: W: spelling-error %description -l en_US anygui -> Guiyang python-easygui.noarch: W: spelling-error %description -l en_US wxPython -> Python, python python3-easygui.noarch: W: spelling-error %description -l en_US dialogs -> dialog, dialog s python3-easygui.noarch: W: spelling-error %description -l en_US anygui -> Guiyang python3-easygui.noarch: W: spelling-error %description -l en_US wxPython -> Python, python python-easygui.src: W: spelling-error %description -l en_US dialogs -> dialog, dialog s python-easygui.src: W: spelling-error %description -l en_US anygui -> Guiyang python-easygui.src: W: spelling-error %description -l en_US wxPython -> Python, python 3 packages and 1 specfiles checked; 0 errors, 9 warnings. [x] Buildroot is correct (%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)) [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x] License field in the package spec file matches the actual license. License type: BSD [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. [x] Spec file is legible and written in American English. [x] Sources used to build the package matches the upstream source, as provided in the spec URL. MD5SUM this package : 954fd5d5214d84874a5f8f9e199e3f13 MD5SUM upstream package: 954fd5d5214d84874a5f8f9e199e3f13 easygui_v0.96_docs.tar.gz [x] Package is not known to require ExcludeArch, OR: [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines. [-] The spec file handles locales properly. [-] ldconfig called in %post and %postun if required. [x] Package must own all directories that it creates. [-] Package requires other packages for directories it uses. [x] Package does not contain duplicates in %files. [x] Permissions on files are set properly. [x] Package has a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [x] Package consistently uses macros. [x] Package contains code, or permissable content. [x] Large documentation files are in a -doc subpackage, if required. [x] Package uses nothing in %doc for runtime. [-] Header files in -devel subpackage, if present. [-] Static libraries in -devel subpackage, if present. [-] Package requires pkgconfig, if .pc files are present. [-] Development .so files in -devel subpackage, if present. [-] Fully versioned dependency in subpackages, if present. [-] Package does not contain any libtool archives (.la). [-] Package contains a properly installed %{name}.desktop file if it is a GUI application. [x] Package does not own files or directories owned by other packages. === SUGGESTED ITEMS === [x] Latest version is packaged. [!] Package does not include license text files separate from upstream. [-] Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x] Reviewer should test that the package builds in mock. Tested on: koji, see above [x] Package should compile and build into binary rpms on all supported architectures. Tested on: noarch [x] Package functions as described. [x] Scriptlets must be sane, if used. [x] The placement of pkgconfig(.pc) files are correct. [x] File based requires are sane. === Notes === 1. Contains separate License file. As stated above, License is BSD. ================ *** APPROVED *** ================ So I did, thanks for the review! New Package SCM Request ======================= Package Name: python-easygui Short Description: Very simple, very easy GUI programming in Python Owners: limb Branches: f16 f15 InitialCC: Git done (by process-git-requests). python-easygui-0.96-1.fc16 has been submitted as an update for Fedora 16. https://admin.fedoraproject.org/updates/python-easygui-0.96-1.fc16 python-easygui-0.96-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/python-easygui-0.96-1.fc15 python-easygui-0.96-1.fc16 has been pushed to the Fedora 16 testing repository. python-easygui-0.96-1.fc15 has been pushed to the Fedora 15 stable repository. python-easygui-0.96-1.fc16 has been pushed to the Fedora 16 stable repository. |
