Bug 702058
| Summary: | self intersecting paths | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Bernard Massot <bmassot> | ||||||
| Component: | lohit-devanagari-fonts | Assignee: | Pravin Satpute <psatpute> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | unspecified | ||||||||
| Version: | rawhide | CC: | fonts-bugs, i18n-bugs, psatpute | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | lohit-devanagari-fonts-2.4.5-3.fc15 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2011-06-16 08:59:52 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Bernard Massot
2011-05-04 16:40:17 UTC
Thanks for reporting bug. Can you submit patch as well against trunk? Created attachment 497905 [details]
patch to remove self intersecting paths
I corrected self intersecting glyphs using FontForge's "remove overlap" function. I had to "simplify" u0938_u094D.half before removing overlapping.
Hi Bernard, i gone through your patch, its very useful -> https://bugzilla.redhat.com/attachment.cgi?id=497905&action=diff It is removing double points like as below 1068 306 -220 l 1,14,-1 1069 306 -220 l 1,0,1 i tried to apply patch on lohit-devanagari but its look like patch: **** malformed patch at line 341: @@ -1304,7 +1282,6 @@ can you please attach Devanagari sfd file, so i can try it. i can see some more things in patch other than just removing self intersecting. how did you worked on this? Created attachment 499639 [details] Lohit Devanagari's FontForge sfd file corresponding to patch 497905 (In reply to comment #3) > i tried to apply patch on lohit-devanagari but its look like patch: **** > malformed patch at line 341: @@ -1304,7 +1282,6 @@ I just used "svn diff". Should I have done it another way? > can you please attach Devanagari sfd file, so i can try it. Done. (In reply to comment #4) > i can see some more things in patch other than just removing self intersecting. > > how did you worked on this? As I said, I had to simplify u0938_u094D.half. Also FontForge keeps some extra info like window size, currently open glyph, etc. I may have done some minor corrections as well, like removing overlap in glyph actually made of two paths (ie. not just only with first and last points overlapping). I don't remember exactly. steps for creating patch : 1) keep copy of "original source" and "modified source" 2) $diff -rup "original source" "modified source" > "patch-name" 3) vi "patch-name" I will test sfd by tomorrow. yesterday while checking changes i found it good. (In reply to comment #5) > Created attachment 499639 [details] > Lohit Devanagari's FontForge sfd file corresponding to patch 497905 Tested the new sfd, it looks nice to me Now Element->Validation->Find Problems->Paths-> Intersecting Paths not reporting any problems Rendering also happening properly I will build in Fedora 16 and Fedora 15 with patch and will push this patch after one week (lets other also test in fedora before making upstream) Thanks Bernard for you contribution !! lohit-devanagari-fonts-2.4.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/lohit-devanagari-fonts-2.4.5-2.fc15 Package lohit-devanagari-fonts-2.4.5-2.fc15: * should fix your issue, * was pushed to the Fedora 15 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing lohit-devanagari-fonts-2.4.5-2.fc15' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/lohit-devanagari-fonts-2.4.5-2.fc15 then log in and leave karma (feedback). Hi Bernard applied patch to upstream !! added your name in the Author list in upstream. see https://fedorahosted.org/lohit/browser/trunk/AUTHORS congrats you are now the contributor to Lohit :) lohit-devanagari-fonts-2.4.5-3.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/lohit-devanagari-fonts-2.4.5-3.fc15 lohit-devanagari-fonts-2.4.5-3.fc15 has been pushed to the Fedora 15 stable repository. If problems still persist, please make note of it in this bug report. |