| Summary: | Fix Coverity resource leaks | ||||||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Retired] 389 | Reporter: | Nathan Kinder <nkinder> | ||||||||||||||||||
| Component: | Admin | Assignee: | Nathan Kinder <nkinder> | ||||||||||||||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Chandrasekar Kannan <ckannan> | ||||||||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||||||||
| Priority: | unspecified | ||||||||||||||||||||
| Version: | 1.2.8 | CC: | benl | ||||||||||||||||||
| Target Milestone: | --- | ||||||||||||||||||||
| Target Release: | --- | ||||||||||||||||||||
| Hardware: | Unspecified | ||||||||||||||||||||
| OS: | Unspecified | ||||||||||||||||||||
| Whiteboard: | |||||||||||||||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||||||||
| Clone Of: | Environment: | ||||||||||||||||||||
| Last Closed: | 2011-05-17 14:08:34 UTC | Type: | --- | ||||||||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||||||||
| Documentation: | --- | CRM: | |||||||||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||||||||
| Bug Depends On: | |||||||||||||||||||||
| Bug Blocks: | 434915 | ||||||||||||||||||||
| Attachments: |
|
||||||||||||||||||||
|
Description
Nathan Kinder
2011-05-04 21:56:09 UTC
Created attachment 496932 [details]
Patch for cov#10829,10828,10827,10826
Created attachment 497173 [details]
Patch for cov#10829,10828,10827,10826,10825,10824
Created attachment 497176 [details]
Pat for cov#10823
Created attachment 497179 [details]
Pat for cov#10822,10821
Created attachment 497180 [details]
Pat for cov#10820,10819
Created attachment 497184 [details]
Pat for cov#10818,10815,10814
Created attachment 497186 [details]
Pat for cov#10816
Created attachment 497188 [details]
Pat for cov#10817
Comment on attachment 497184 [details]
Pat for cov#10818,10815,10814
A bit curious why ds_get_conf_from_file does not call ds_free_config, but the code is doing the right thing.
Comment on attachment 497173 [details] Patch for cov#10829,10828,10827,10826,10825,10824 Could you double check 2 comments (one starting from line 1188 and another from line 1197) are not duplicated? It might be a diff tool issue, I guess... https://bugzilla.redhat.com/attachment.cgi?id=497173&action=diff#a/admserv/cgi-src40/htmladmin.c_sec8 (In reply to comment #9) > Comment on attachment 497184 [details] > Pat for cov#10818,10815,10814 > > A bit curious why ds_get_conf_from_file does not call ds_free_config, but the > code is doing the right thing. I really added ds_free_config() as a function that goes along with ds_get_config(). The ds_get_conf_from_file() function is the function that is used beneath ds_get_config() to actually build the list. Since this function has the logic of the internals of the way the list is allocated, I made it just do the deallocation itself too. (In reply to comment #10) > Comment on attachment 497173 [details] > Patch for cov#10829,10828,10827,10826,10825,10824 > > Could you double check 2 comments (one starting from line 1188 and another from > line 1197) are not duplicated? It might be a diff tool issue, I guess... > > https://bugzilla.redhat.com/attachment.cgi?id=497173&action=diff#a/admserv/cgi-src40/htmladmin.c_sec8 I moved the comment to the top of the code block, but forgot to remove the original comment. I'll remove the duplicate before I push the patch. Pushed patches to master. Thanks to Noriko for her reviews! Counting objects: 62, done. Delta compression using up to 2 threads. Compressing objects: 100% (43/43), done. Writing objects: 100% (43/43), 6.45 KiB, done. Total 43 (delta 32), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/admin.git ab4472e..b427aa1 master -> master |