| Summary: | qpid java client crashes with NPE at org.apache.qpid.client.AMQAnyDestination.getTopicName(AMQAnyDestination.java:75) | ||
|---|---|---|---|
| Product: | Red Hat Enterprise MRG | Reporter: | Frantisek Reznicek <freznice> |
| Component: | qpid-java | Assignee: | Rajith Attapattu <rattapat+nobody> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Frantisek Reznicek <freznice> |
| Severity: | urgent | Docs Contact: | |
| Priority: | urgent | ||
| Version: | Development | CC: | esammons, gsim, iboverma |
| Target Milestone: | 2.0 | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2012-12-07 17:42:01 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Bug Depends On: | |||
| Bug Blocks: | 667771 | ||
|
Description
Frantisek Reznicek
2011-05-05 06:54:25 UTC
This is caused due to the address not being resolved properly. All though this is not a blocker, we probably needs to fix this. I will be posting a patch upstream shortly for review. This is caused due to the address not being resolved properly. All though this is not a blocker, we probably needs to fix this. I will be posting a patch upstream shortly for review. This issue is tracked in upstream via QPID-3254 This went through the review process in upstream Qpid project. See https://reviews.apache.org/r/706/ Following is a list of commits that went in for this bug. 1. http://svn.apache.org/viewvc?view=revision&revision=1102002 This commit added logic to resolve an address string to ensure we have enough information to handle corner cases like addresses without subjects. It also adds null checks for getRoutingKey() method and getTopicName() method in both AMQTopic and AMQAnyDestination classes, which causes the NPE mentioned in this bug. 2. http://svn.apache.org/viewvc?view=revision&revision=1102102 Added logic to ensure only Topics are used in creating durable subs to avoid any unnecessary complications arising as a result of using named Queues. It also marks the private queue being used as durable even if marked otherwise in the address string. 3. http://svn.apache.org/viewvc?rev=1103884&view=rev Changed the default value for routing key based on a review comment by Robert Godfrey. The issue has been corrected on qpid-java-0.10-6, tested on RHEL 5.6/6.1 i[36]86 / x86_64, no more NPE seen. -> VERIFIED Thanks Frantisek for the quick work. The fixes were ported to the release branch at. http://mrg1.lab.bos.redhat.com/cgit/qpid.git/commit/?h=mrg_2.0.x&id=9e87f9c75779a3058dd27c5524ce9f85706f5321 http://mrg1.lab.bos.redhat.com/cgit/qpid.git/commit/?h=mrg_2.0.x&id=c65f5a3ae1713e7296d097d335b64befccd29651 http://mrg1.lab.bos.redhat.com/cgit/qpid.git/commit/?h=mrg_2.0.x&id=8a923a906baea478bbbc3eaf8d54ff0f03f68945 |