Bug 702599

+++ This bug was initially created as a clone of Bug #702418 +++

+++ This bug was initially created as a clone of Bug #690523 +++

 rd.driver.pre, rdloaddriver=, rd.driver.blacklist, and rdblacklist= all use the wrong index var for the inner loop, e.g.:

for p in $(getargs rd.driver.pre rdloaddriver=); do 
    ( 
        IFS=,
        for p in $i; do 
            modprobe $p 2>&1 | vinfo
        done
    )
done

fix is:

 for p in $(getargs rd.driver.pre rdloaddriver=); do 
     ( 
         IFS=,
-        for p in $i; do 
-            modprobe $p 2>&1 | vinfo
+        for i in $p; do 
+            modprobe $i 2>&1 | vinfo
         done
     )
 done

Proposing this for 6.2 but also to be backported to 6.0.z and 6.1.z.

A working rdloaddriver= should provide a workaround for a problematic limitation in the kernel (bug #658636) -- working that kernel bug upstream may take longer than we'd like.

--- Additional comment from msnitzer on 2011-05-05 11:52:15 EDT ---

(In reply to comment #0)

> Proposing this for 6.2 but also to be backported to 6.0.z and 6.1.z.
> 
> A working rdloaddriver= should provide a workaround for a problematic
> limitation in the kernel (bug #658636) -- working that kernel bug upstream may
> take longer than we'd like.

I meant to reference kernel Bug #690523.

--- Additional comment from msnitzer on 2011-05-05 12:08:34 EDT ---

(In reply to comment #0)

> Proposing this for 6.2 but also to be backported to 6.0.z and 6.1.z.

Sorry for the noise.. This is only an upstream/fedora issue!

I just assumed RHEL6.1's dracut would've been rebased and/or already had upstream's modules.d/90kernel-modules/parse-kernel.sh changes.

RHEL6.0's parse-kernel.sh only has:

#!/bin/sh

for p in $(getargs rdloaddriver=); do 
        modprobe $p
done

and RHEL6.1's parse-kernel.sh has:

#!/bin/sh

for i in $(getargs rdloaddriver=); do 
    ( 
        IFS=,
        for p in $i; do 
            modprobe $p 2>&1 | vinfo
        done
    )
done

Closing NOTABUG!

--- Additional comment from harald on 2011-05-06 06:08:11 EDT ---

Thanks!

Pushed upstream!

http://git.kernel.org/?p=boot/dracut/dracut.git;a=commitdiff;h=3cf14ae1aebb8dde4a053b23211fd9c81e4b35db