Bug 702998

Summary: Review Request: pyttsx - Cross platform text-to-speech
Product: [Fedora] Fedora Reporter: PRABIN KUMAR DATTA <linux.n.pkd>
Component: Package ReviewAssignee: Fabian Affolter <mail>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, mail, nospam, notting, pahan
Target Milestone: ---Flags: mail: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pyttsx-1.0-1.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-06-29 21:57:09 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description PRABIN KUMAR DATTA 2011-05-08 22:42:21 UTC
Spec URL: http://prabindatta.fedorapeople.org/SPECS/pyttsx.spec
SRPM URL: http://prabindatta.fedorapeople.org/SRPMS/pyttsx-1.0-1.fc14.src.rpm
Description: 
pyttsx is a Python package supporting common text-to-speech engines. 
It currently supports SAPI5, NSSpeechSynthesizer, and espeak.

Comment 1 PRABIN KUMAR DATTA 2011-05-08 22:45:36 UTC
Just for testing:
//-- Python code--
import pyttsx
engine = pyttsx.init()
engine.say('What is your name?')
engine.say('My name is Prabin Kumar Datta')
engine.runAndWait()
--------------------//
Works fine!!

Comment 2 PRABIN KUMAR DATTA 2011-05-08 22:46:10 UTC
Koji Build:
http://koji.fedoraproject.org/koji/taskinfo?taskID=3058818

Comment 3 Fabian Affolter 2011-06-19 14:18:14 UTC
Package Review
==============

Package: 

Key:
 - = N/A
 x = Check
 ! = Problem
 ? = Not evaluated

=== REQUIRED ITEMS ===
 [x] Package is named according to the Package Naming Guidelines
 [x] Spec file name must match the base package %{name}, in the format %{name}.spec
 [x] Package meets the Packaging Guidelines
 [x] Package successfully compiles and builds into binary RPMs on at least one
supported architecture
     Tested: http://koji.fedoraproject.org/koji/taskinfo?taskID=3141408
 [x] Rpmlint output:
     Source RPM:
     [fab@laptop021 SRPMS]$ rpmlint pyttsx-1.0-1.fc14.src.rpm 
     pyttsx.src: W: spelling-error %description -l en_US espeak -> speak, bespeak, e speak
     pyttsx.src: W: file-size-mismatch parente-pyttsx-86fcc6e.tar.gz = 25151, https://github.com/parente/pyttsx/tarball/master/parente-pyttsx-86fcc6e.tar.gz = 25184
     1 packages and 0 specfiles checked; 0 errors, 2 warnings.
     Binary RPM(s):
     [fab@laptop021 noarch]$ rpmlint pyttsx-1.0-1.fc15.noarch.rpm 
     1 packages and 0 specfiles checked; 0 errors, 0 warnings.
 [x] Package is not relocatable
 [x] Buildroot is correct (if it's still used)
     master   : %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
     spec file: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
 [x] Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines.
 [x] License field in the package spec file matches the actual license
     License type: BSD
 [x] If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc

 [x] Spec file is legible and written in American English
 [] Sources used to build the package matches the upstream source, as provided
in the spec URL
     Upstream source: 
     Build source:    
 [x] Package is not known to require ExcludeArch
 [x] Architecture independent packages have: BuildArch: noarch
 [x] All build dependencies are listed in BuildRequires, except for any that are listed in the exceptions section of Packaging Guidelines.
 [-] The spec file handles locales properly.  %find_lang used for locales
 [-] %{optflags} or RPM_OPT_FLAGS are honoured
 [-] ldconfig called in %post and %postun if required
 [x] %install starts with rm -rf %{buildroot} or $RPM_BUILD_ROOT (no longer needed)
 [-] Package use %makeinstall only when make install DESTDIR=... doesn't work.
 [x] Package must own all directories that it creates
 [x] Package requires other packages for directories it uses
 [x] Package does not own files or directories owned by other packages
 [x] Package does not contain duplicates in %files
 [x] Permissions on files are set properly. %defattr(-,root,root,-) is in every %files section (no longer needed)
 [x] Package uses nothing in %doc for runtime
 [-] Package has a %clean section, which contains rm -rf %{buildroot} or $RPM_BUILD_ROOT (no longer needed)
 [x] Included tests passed successfully 
 [x] Package consistently uses macros
 [x] Package contains code, or permissable content
 [x] Included filenames are in UTF-8

 [-] Large documentation files are in a -doc subpackage, if required
 [-] Header files (.h) in -devel subpackage, if present
 [-] Fully versioned dependency in subpackage, if present
 [-] Static libraries (.a) in -static subpackage, if present
 [-] Package requires pkgconfig, if .pc files are present
 [-] Development .so files in -devel subpackage, if present
 [x] Package does not contain any libtool archives (.la)
 [-] -debuginfo subpackage is present and looks complete
 [x] No pre-built binaries (.a, .so*, executable)
 
 [-] Package contains a properly installed .desktop file if it is a GUI application
 [-] Follows desktop entry spec
 [-] Valid .desktop Name
 [-] Valid .desktop GenericName
 [-] Valid .desktop Categories
 [-] Valid .desktop StartupNotify
 [-] .desktop file installed with desktop-file-install in %install

=== SUGGESTED ITEMS ===
 [-] Timestamps preserved with cp and install
 [x] Spec use %global instead of %define
 [-] Uses parallel make (%{?_smp_mflags})
 [x] Latest version is packaged
 [-] Package does not include license text files separate from upstream
 [-] Description and summary sections in the package spec file contains
translations for supported Non-English languages, if available
 [x] Package functions as described
 [-] Scriptlets must be sane, if used
 [-] The placement of pkgconfig(.pc) files is correct
 [-] File based requires are sane
 [x] Changelog in allowed format

I see no blocker, package APPROVED.

Comment 4 PRABIN KUMAR DATTA 2011-06-19 16:50:54 UTC
> I see no blocker, package APPROVED.
Thank You!

Comment 5 PRABIN KUMAR DATTA 2011-06-19 16:52:14 UTC
New Package SCM Request
=======================
Package Name: pyttsx
Short Description: Cross platform text-to-speech
Owners: prabindatta
Branches: f14 f15 f16 el6
InitialCC:

Comment 6 Gwyn Ciesla 2011-06-19 22:19:15 UTC
Git done (by process-git-requests).

Comment 7 Fedora Update System 2011-06-20 11:56:49 UTC
pyttsx-1.0-1.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/pyttsx-1.0-1.fc14

Comment 8 Fedora Update System 2011-06-20 12:07:05 UTC
pyttsx-1.0-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/pyttsx-1.0-1.fc15

Comment 9 Fedora Update System 2011-06-20 12:37:19 UTC
pyttsx-1.0-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/pyttsx-1.0-1.el6

Comment 10 Fedora Update System 2011-06-21 17:06:36 UTC
pyttsx-1.0-1.fc14 has been pushed to the Fedora 14 testing repository.

Comment 11 Fedora Update System 2011-06-29 21:57:04 UTC
pyttsx-1.0-1.fc14 has been pushed to the Fedora 14 stable repository.

Comment 12 Fedora Update System 2011-06-29 22:01:57 UTC
pyttsx-1.0-1.fc15 has been pushed to the Fedora 15 stable repository.

Comment 13 Fedora Update System 2011-07-08 16:04:17 UTC
pyttsx-1.0-1.el6 has been pushed to the Fedora EPEL 6 stable repository.

Comment 14 Henry Kroll 2013-09-23 05:36:59 UTC
Broken in F19.

Python 2.7.5 (default, Aug 22 2013, 09:31:58) 
[GCC 4.8.1 20130603 (Red Hat 4.8.1-1)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import pyttsx
>>> engine = pyttsx.init()
Segmentation fault

dmesg...
Sep 22 22:32:08 localhost kernel: [13155.633938] python[3894]: segfault at 0 ip 00000039134944b7 sp 00007fff05a63cb8 error 4 in libc-2.17.so[3913400000+1b6000