Bug 703067

Summary:	The guest installation is still started although close the Customize configuration page
Product:	Red Hat Enterprise Linux 6	Reporter:	mliu
Component:	virt-manager	Assignee:	Cole Robinson <crobinso>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	6.1	CC:	dyuan, mliu, mzhan, zpeng
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:	Cause: virt-manager provided no way to undo customized changes made to a VM before initiated guest install. Consequence: hitting the 'X' for the 'customize before install' dialog would unintuitively start the install Fix: allow canceling the customize step, throwing away the custom changes and returning to the final screen of the 'new vm' wizard Result: 'X' button in customize dialog now means 'cancel'	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-12-06 16:14:01 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description mliu 2011-05-09 08:03:45 UTC

Description of problem:
I install new guest and check the checkbox "Customize configuration before install", On the pop up configuration page, I click "X" to close it, the installation is still started.  

Version-Release number of selected component (if applicable):
libvirt-0.8.7-18.el6.x86_64
virt-manager-0.8.6-4.el6.noarch

How reproducible:
Always

Steps to Reproduce:
1.Open virtual manager
2.create a new virtual machine
3.input the values and on the step 5, check the check box "Customize configuration before install", click "Finish"
4.On the pop up configuration page, do some updates, such as change Disk Bus to IDE, and click "Apply" 
5.Click "X" at the top right corner
  
Actual results:
the installation is started, and the Disk Bus is already updated to IDE

Expected results:
the installation should quit. Or there is a prompting message to let customer choose whether continue or not.

Additional info:

Comment 1 Cole Robinson 2011-07-19 01:36:59 UTC

Fixed upstream:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=ad5bb2ab48cd45ee919892fe1e6f20c00b03a4f7

There's a new 'cancel' button in that dialog, which throws away the custom changes and drops you back to the New VM wizard. The window 'X' acts the same.

Comment 2 Cole Robinson 2011-07-28 15:29:20 UTC

Fixed in virt-manager-0.9.0-2.el6

Comment 4 zhe peng 2011-08-05 02:23:59 UTC

this bug can reproduce with virt-manager-0.8.6-4.el6

verified with:
virt-manager-0.9.0-5.el6
libvirt-0.9.4-1.el6

step:
1.Open virtual manager
2.create a new virtual machine
3.input the values , check the check box "Customize
configuration before install", click "Finish"
4.On the pop up configuration page, do some updates and click "Apply" 

test both "Cancel" button and the window 'X', it will drop users setting and back to wizard, guest not start to install,the bug fixed.
verification passed.

Comment 5 Cole Robinson 2011-11-07 17:44:22 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Cause:
virt-manager provided no way to undo customized changes made to a VM before initiated guest install.

Consequence:
hitting the 'X' for the 'customize before install' dialog would unintuitively start the install

Fix:
allow canceling the customize step, throwing away the custom changes and returning to the final screen of the 'new vm' wizard

Result:
'X' button in customize dialog now means 'cancel'

Comment 6 errata-xmlrpc 2011-12-06 16:14:01 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1642.html