Bug 703178

I'll take this as well as bug 703248 (actually I overlooked this in the NEW RR list).

It looks that the issues mentioned in bug 703248 were already addressed.  However, it fails to build:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3064358

(In reply to comment #1)
> I'll take this as well as bug 703248 (actually I overlooked this in the NEW RR
> list).
> 
> It looks that the issues mentioned in bug 703248 were already addressed. 
> However, it fails to build:
> 
> http://koji.fedoraproject.org/koji/taskinfo?taskID=3064358

Maybe I'm misreading the log, but it looks like the build failure isn't due to the RPM or specfile but something on the build system itself:

+ cd /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2
/var/tmp/rpm-tmp.K4xWdp: line 29: cd: /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2: No such file or directory
RPM build errors:
error: Bad exit status from /var/tmp/rpm-tmp.K4xWdp (%check)
    Bad exit status from /var/tmp/rpm-tmp.K4xWdp (%check)
Child returncode was: 1
EXCEPTION: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps builddir/build/SPECS/rubygem-declarative_authorization.spec']
Traceback (most recent call last):
  File "/usr/lib/python2.6/site-packages/mock/trace_decorator.py", line 70, in trace
    result = func(*args, **kw)
  File "/usr/lib/python2.6/site-packages/mock/util.py", line 325, in do
    raise mock.exception.Error, ("Command failed. See logs for output.\n # %s" % (command,), child.returncode)
Error: Command failed. See logs for output.
 # ['bash', '--login', '-c', 'rpmbuild -bb --target noarch --nodeps builddir/build/SPECS/rubygem-declarative_authorization.spec']
LEAVE do --> EXCEPTION RAISED

I can build the RPM both from spec and SRPM locally without a problem. So is this something I can fix or something that needs to be fixed in Koji?

(In reply to comment #2)

> + cd /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2
> /var/tmp/rpm-tmp.K4xWdp: line 29: cd:
> /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2: No such file or
> directory

It seems to be accessing a file outside of %buildroot.  I guess you need to prepend %{buildroot} to %{geminstdir} like:

 %check
 cd %{buildroot}%{geminstdir}
 rake test

However, even then it still fails to build on F-15:

 Using Rails from RubyGems (> 2.1.0)
 /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:53:in `gem_original_require': no such file to load -- initializer (LoadError)

Maybe the test suite cannot run with Rails 3 in standalone mode.  I think enabling test suite could be postponed until the upstream fixes this.

(In reply to comment #3)
> (In reply to comment #2)
> 
> > + cd /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2
> > /var/tmp/rpm-tmp.K4xWdp: line 29: cd:
> > /usr/lib/ruby/gems/1.8/gems/declarative_authorization-0.5.2: No such file or
> > directory
> 
> It seems to be accessing a file outside of %buildroot.  I guess you need to
> prepend %{buildroot} to %{geminstdir} like:
> 
>  %check
>  cd %{buildroot}%{geminstdir}
>  rake test
> 
> However, even then it still fails to build on F-15:
> 
>  Using Rails from RubyGems (> 2.1.0)
>  /usr/lib/ruby/site_ruby/1.8/rubygems/custom_require.rb:53:in
> `gem_original_require': no such file to load -- initializer (LoadError)
> 
> Maybe the test suite cannot run with Rails 3 in standalone mode.  I think
> enabling test suite could be postponed until the upstream fixes this.

I spoke with the upstream, Matthu Huggins, and he verified that the tests depend on Rails 3. I'm going to work with him to fix them up to run on F14/Rails 2.3.8 and F15/Rails 3 going forward.

(In reply to comment #3)
> Maybe the test suite cannot run with Rails 3 in standalone mode.  I think
> enabling test suite could be postponed until the upstream fixes this.

In that case, can we move forward with approving the package?

Ping reviewer - can we move forward with the package review, please?

Sorry for not getting back to you earlier.  The packaging looks fine except %check.
Also it would be nice to resolve "File listed twice" warning when building, as noted in bug 703248.

APPROVED.

New Package SCM Request
=======================
Package Name: rubygem-declarative_authorization
Short Description: The declarative_authorization plug in provides readable auth rules for Rails.
Owners: mcpierce
Branches: F15
InitialCC: mcpierce

Git done (by process-git-requests).

Thanks for the quick repo creation, Jason!