Bug 703461

Summary: Review Request: perl-threads-tbb - Interface to the Threading Building Blocks (TBB) API
Product: [Fedora] Fedora Reporter: Petr Pisar <ppisar>
Component: Package ReviewAssignee: Marcela Mašláňová <mmaslano>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review, notting
Target Milestone: ---Flags: mmaslano: fedora-review+
j: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: perl-threads-tbb-0.02-1.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-19 07:18:22 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 703456    
Bug Blocks:    

Description Petr Pisar 2011-05-10 12:14:57 UTC
Spec URL: http://ppisar.fedorapeople.org/perl-threads-tbb/perl-threads-tbb.spec
SRPM URL: http://ppisar.fedorapeople.org/perl-threads-tbb/perl-threads-tbb-0.02-1.fc14.src.rpm
Description:
This module provides access to a few core TBB API functions to Perl programs.
The algorithms employed by TBB are quite different to threads as provided by
"use threads;" - instead of directly starting threads and managing their
activity and communication/synchronization, an API is provided that provides
data parallelism.

Comment 1 Marcela Mašláňová 2011-05-18 08:51:42 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license OK
- license field must match actual license OK
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
 http://koji.fedoraproject.org/koji/taskinfo?taskID=3078258
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK

rpm -qp --provides ~/Downloads/perl-threads-tbb-0.02-1.fc16.x86_64.rpm 
perl(threads::tbb) = 0.02
perl-threads-tbb = 0.02-1.fc16
perl-threads-tbb(x86-64) = 0.02-1.fc16
rpm -qp --requires ~/Downloads/perl-threads-tbb-0.02-1.fc16.x86_64.rpm | sort
libc.so.6()(64bit)  
libc.so.6(GLIBC_2.2.5)(64bit)  
libc.so.6(GLIBC_2.4)(64bit)  
libgcc_s.so.1()(64bit)  
libgcc_s.so.1(GCC_3.0)(64bit)  
libm.so.6()(64bit)  
libstdc++.so.6()(64bit)  
libstdc++.so.6(CXXABI_1.3)(64bit)  
libstdc++.so.6(GLIBCXX_3.4.15)(64bit)  
libstdc++.so.6(GLIBCXX_3.4)(64bit)  
libtbb.so.2()(64bit)  
perl >= 0:5.008
perl(Carp)  
perl(ExtUtils::XSpp) >= 0.01
perl(:MODULE_COMPAT_5.12.3)  
perl(strict)  
perl(warnings)  
perl(XSLoader)  
rpmlib(CompressedFileNames) <= 3.0.4-1
rpmlib(FileDigests) <= 4.6.0-1
rpmlib(PayloadFilesHavePrefix) <= 4.0-1
rpmlib(PayloadIsXz) <= 5.2-1
rtld(GNU_HASH)

APPROVED

Comment 2 Petr Pisar 2011-05-18 10:09:11 UTC
New Package SCM Request
=======================
Package Name: perl-threads-tbb 
Short Description: Interface to the Threading Building Blocks (TBB) API
Owners: ppisar mmaslano psabata
Branches: 
InitialCC: perl-sig

Comment 3 Jason Tibbitts 2011-05-18 22:22:20 UTC
Git done (by process-git-requests).