Bug 703630

Summary:	Move fullpage chart link closer to graph [RFE]
Product:	Red Hat Enterprise MRG	Reporter:	Trevor McKay <tmckay>
Component:	cumin	Assignee:	Chad Roberts <croberts>
Status:	CLOSED ERRATA	QA Contact:	Jan Sarenik <jsarenik>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.0	CC:	croberts, jsarenik, ltoscano, matt
Target Milestone:	2.0.1
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	cumin-0.1.4863-1	Doc Type:	Bug Fix
Doc Text:	C: None C: Difficulty in associating the fullpage link with the appropriate graph F: Fullpage chart link moved to align with its associated graph R: No more difficulty	Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-09-07 16:42:50 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	723887

Description Trevor McKay 2011-05-10 21:00:04 UTC

Description of problem:

The fullpage link for charts is in the extreme upper right corner of the space allocated by the chart.  Consider moving it in closer to the chart, maybe aligned with the 10min/1hr/1day radio buttons and the Y-axis unit labels.

Also, consider supporting a double click on the graph to go to fullpage mode.

Comment 1 Chad Roberts 2011-05-19 18:34:21 UTC

Available in revision 4772.

Lining-up the full page icon precisely with the y-axis labels proves to be difficult/not possible since the labels all come from the Flash object and are not always the same width.  In lieu of doing that, I have lined up the icon with the "1 day, 1 hour, 10 minutes" line and have place it near the y-axis for most graphs (graphs that have larger numbers).  For graphs that have single-digit y-axis labels, the horizontal position will be slightly off the y-axis labels.

For now, I don't think that "double-click on the graph" support is necessary since we have made the full page icon more prominent.  I'm not sure that it's is a good idea in the long run either since we may be able to build additional functionality into the graphs themselves.

Comment 2 Matthew Farrellee 2011-06-15 14:20:29 UTC

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
C: None
C: Difficulty in associating the fullpage link with the appropriate graph
F: Fullpage chart link moved to align with its associated graph
R: No more difficulty

Comment 3 Jan Sarenik 2011-06-24 09:42:23 UTC

You have to note that the same routine is used to draw a full-page icon
in the default Overview page (e.g. Deepest Message Queues) where it is
ugly now. There either needs to be a different mechanism to draw that icon
in these two (maybe more?) modes, or a better place should be found.

Tested on cumin-0.1.4840-1.el5

Comment 4 Chad Roberts 2011-06-24 14:00:14 UTC

Good catch.  I have returned the Messaging overview page fullpage icons to their old location.  Their position is now computed separately from the chart fullpage icons.

Fixed in revision 4852.

Comment 6 Jan Sarenik 2011-07-22 11:29:20 UTC

Verified with cumin-0.1.4878-1.el5

Comment 7 errata-xmlrpc 2011-09-07 16:42:50 UTC

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHSA-2011-1249.html