| Summary: | Review Request: sound-theme-acoustic - Sound theme made on an acoustic guitar | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | fedoraparked |
| Component: | Package Review | Assignee: | Elad Alfassa <elad> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | elad, fedora-package-review, mattia.verga |
| Target Milestone: | --- | Flags: | elad:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2020-05-27 16:44:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
fedoraparked
2011-05-11 08:06:02 UTC
Since you don't need a sponsor anymore, I can do the review. :) -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers + Package meets naming and packaging guidelines
+ Spec file matches base package name.
+ Spec has consistent macro usage.
+ Meets Packaging Guidelines.
+ License
+ License field in spec matches
+ License file included in package
+ Spec in American English
+ Spec is legible.
- Package needs ExcludeArch
- BuildRequires correct
- Spec handles locales/find_lang
- Package is relocatable and has a reason to be.
+ Package has %defattr and permissions on files is good.
- Package has a correct %clean section.
- Package has correct buildroot
%{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
+ Package is code or permissible content.
- Doc subpackage needed/used.
- Packages %doc files don't affect runtime.
- Headers/static libs in -devel subpackage.
- Spec has needed ldconfig in post and postun
- .pc files in -devel subpackage/requires pkgconfig
- .so files in -devel subpackage.
- -devel package Requires: %{name} = %{version}-%{release}
- .la files are removed.
- Package is a GUI app and has a .desktop file
+ Package compiles and builds on at least one arch.
+ Package has no duplicate files in %files.
- Package doesn't own any directories other packages own.
+ Package owns all the directories it creates.
+ No rpmlint output.
+ final provides and requires are sane:
SHOULD Items:
- Should build in mock.
- Should build on all supported archs
+ Should function as described.
- Should have sane scriptlets.
- Should have subpackages require base package with fully versioned depend.
+ Should have dist tag
- Should package latest version
- check for outstanding bugs on package. (For core merge reviews)
Seems fine, package is APPROVED.
New Package SCM Request ======================= Package Name: sound-theme-acoustic Short Description: Sound theme made on an acoustic guitar Owners: AnujMore Branches: f14 f15 f16 InitialCC: AnjuMore is not a falid FAS account name. he has a typo there, his FAS name is anujmore <zodbot> elad661: User: anujmore, Name: Anuj More, email: anujmorex, Creation: 2010-01-23, IRC Nick: execat, Timezone: Asia/Kolkata, Locale: en, Extension: 5143354, GPG key ID: , Status: active <zodbot> elad661: Unapproved Groups: marketing magazine <zodbot> elad661: Approved Groups: fedorabugs packager gitmuffin cla_fedora cla_done ambassadors cla_fpca Anuj, please fix your SCM request. -- Fedora Bugzappers volunteer triage team https://fedoraproject.org/wiki/BugZappers New Package SCM Request ======================= Package Name: sound-theme-acoustic Short Description: Sound theme made on an acoustic guitar Owners: anujmore Branches: f14 f15 f16 InitialCC: Git done (by process-git-requests). This package was approved and imported in repositories, but this review ticket was never closed. I'm closing it now. |