Bug 703784

Summary: AttributeError: 'NoneType' object has no attribute 'isDisk'
Product: [Fedora] Fedora Reporter: Ales Kozumplik <akozumpl>
Component: anacondaAssignee: Anaconda Maintenance Team <anaconda-maint-list>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: anaconda-maint-list, dcantrell, fullung, jonathan, jzeleny, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard: anaconda_trace_hash:8f86d895964676574e12b4c6a1365e96f8d814a35d9fc93a04b404ef2f7d75d9
Fixed In Version: anaconda-18.3 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-08-07 18:05:30 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Attached traceback automatically from anaconda. none

Description Ales Kozumplik 2011-05-11 09:08:04 UTC
The following was filed automatically by anaconda:
anaconda 16.7.20110511.e7e2 exception report
Traceback (most recent call first):
  File "/tmp/updates/pyanaconda/bootloader.py", line 1487, in _gpt_disk_has_bios_boot
    if device.isDisk and getattr(device.format, "labelType", None) == "gpt":
  File "/tmp/updates/pyanaconda/storage/partitioning.py", line 112, in _schedulePartitions
    if gpt_check and gpt_check(boot_disk):
  File "/tmp/updates/pyanaconda/storage/partitioning.py", line 230, in doAutoPartition
    _schedulePartitions(anaconda.storage, disks)
  File "/tmp/updates/pyanaconda/dispatch.py", line 327, in dispatch
    self.dir = self.steps[self.step].target(self.anaconda)
  File "/tmp/updates/pyanaconda/text.py", line 508, in run
    self.anaconda.dispatch.dispatch()
  File "/tmp/updates/pyanaconda/dispatch.py", line 281, in run
    self.anaconda.intf.run(self.anaconda)
  File "/tmp/updates/anaconda", line 806, in <module>
    anaconda.dispatch.run()
AttributeError: 'NoneType' object has no attribute 'isDisk'

Comment 1 Ales Kozumplik 2011-05-11 09:08:10 UTC
Created attachment 498233 [details]
Attached traceback automatically from anaconda.

Comment 2 Ales Kozumplik 2011-05-11 09:14:24 UTC
hitting this during text installation on today's rawhide. related to bug 701228?

Comment 3 David Lehman 2011-05-11 13:45:36 UTC
Try this:

diff --git a/pyanaconda/storage/partitioning.py b/pyanaconda/storage/partitionin
index 80ba4ca..428d109 100644
--- a/pyanaconda/storage/partitioning.py
+++ b/pyanaconda/storage/partitioning.py
@@ -109,7 +109,7 @@ def _schedulePartitions(storage, disks):
             gpt_check = getattr(storage.platform.bootloader,
                                 "_gpt_disk_has_bios_boot",
                                 None)
-            if gpt_check and gpt_check(boot_disk):
+            if boot_disk and gpt_check and gpt_check(boot_disk):
                 # there's already a bios boot partition on the gpt boot disk
                 log.info("skipping bios boot request since boot disk has one")
                 continue

Comment 4 Ales Kozumplik 2011-05-11 16:02:38 UTC
And now I can't reproduce 703784 with or without your patch.

So I think you can go ahead.

Ales

Comment 5 Chris Lumens 2012-08-03 19:29:26 UTC
I believe this should be fixed in F18 Alpha.  Please test and let us know.

Comment 6 Ales Kozumplik 2012-08-06 06:37:22 UTC
Hmm, not sure how I did that originally but given it's an ABRT reported bug with no more reporters I think it's safe to assume it has gone now. OK to close this for me.

Comment 7 Albert Strasheim 2012-11-08 15:07:04 UTC
Reproduced this with a ks.cfg with Fedora 16:

install
firewall --disabled
cdrom
rootpw --plaintext secret
auth  --useshadow  --passalgo=md5
text
keyboard us
lang en_US
selinux --disabled
skipx
logging --level=info
timezone --isUtc Etc/UTC
bootloader --location=mbr
zerombr
clearpart --all
part / --asprimary --fstype="ext4" --grow --size=1
network --bootproto=dhcp --device=eth0
shutdown
%packages
@base
%end

in an attempt to use Anaconda to create the base of a complete initramfs

Any chance of a fix for F16's Anaconda?

Comment 8 Chris Lumens 2012-11-08 15:15:22 UTC
No, we don't do updates of anaconda for previous releases.