Bug 703921

Summary: dates do not appear in contract selection dialog
Product: Red Hat Enterprise Linux 6 Reporter: Chris Duryee <cduryee>
Component: subscription-managerAssignee: John Sefler <jsefler>
Status: CLOSED ERRATA QA Contact: John Sefler <jsefler>
Severity: high Docs Contact:
Priority: urgent    
Version: 6.1CC: alikins, jmolet, jwest
Target Milestone: rcKeywords: ZStream
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Previously, the "Start Date" and "End Date" fields in the Contract Selection dialog window of the subscription-manager-gui utility were not populated. With this update, the dates are displayed as expected.
 Story Points: ---
Clone Of: 703920 Environment:
Last Closed: 2011-12-06 17:14:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 703920    
Bug Blocks: 712408    
Attachments:
Description Flags
start/end dates are now displayed in the contract selection dialog
none
also verifying merged fix from 702029 none

Description Chris Duryee 2011-05-11 16:55:37 UTC 
+++ This bug was initially created as a clone of Bug #703920 +++

Created attachment 498338 [details]
no dates in dialog

Description of problem:

Dates do not appear in contract selection dialog in sm-gui (see screenshot). Additionally, this error is thrown to stdout:

/usr/share/rhsm/subscription_manager/gui/contract_selection.py:60: Warning: unable to set property `date' of type `PyObject' from value of type `gchararray'
  self.contract_selection_win.show_all()
/usr/sbin/subscription-manager-gui:121: Warning: unable to set property `date' of type `PyObject' from value of type `gchararray'
  sys.exit(gtk.main() or 0)


Version-Release number of selected component (if applicable): 0.95.5.13


How reproducible: every time


Steps to Reproduce:
1. go to all available subscriptions tab
2. subscribe to something
3. note the lack of dates in dialog
  
Actual results:

no start/end dates shown

Expected results:

start/end dates shown
Comment 1 Adrian Likins 2011-06-07 19:33:06 UTC 
commit 47646c5b67d1f23256862b9845e2ab357b5b224b
Author: Adrian Likins <alikins>
Date:   Wed May 11 13:17:34 2011 -0400

    703921: contract selection was not showing dates for pools
    
    contract_selection dialog was expecting datetime objects
    that it was passing to a CellRendererDate, but was getting
    strings of is8601 dates instead, so convert those strings
    to datetime. Also, the model was expecting strings, change
    to gobject.TYPE_PYOBJECT
    
    (merge)
Comment 2 J.C. Molet 2011-06-08 14:38:14 UTC 
Trying in latest builds:

subscription-manager-0.95.14-1.git.4.11aa664.el6.x86_64
subscription-manager-firstboot-0.95.14-1.git.4.11aa664.el6.x86_64
subscription-manager-gnome-0.95.14-1.git.4.11aa664.el6.x86_64

when I click on "subscribe" in order to get to a contract selection dialog i get this traceback:

(subscription-manager-gui:2711): libglade-WARNING **: unknown property `mnemonics_visible' for class `GtkWindow'
Traceback (most recent call last):
  File "/usr/share/rhsm/gui/allsubs.py", line 259, in subscribe_button_clicked
    self.contract_selection.add_pool(pool)
  File "/usr/share/rhsm/gui/contract_selection.py", line 93, in add_pool
    "%s / %s" % (pool['consumed'], quantity),
NameError: global name 'quantity' is not defined

and the dialog does not show.
Comment 3 Adrian Likins 2011-06-09 18:45:05 UTC 
commit 5c3b44004f0ffdcd00ed1f519f44fd9dee14c1cc
Author: Adrian Likins <alikins>
Date:   Wed May 11 13:17:34 2011 -0400

    703921: contract selection was not showing dates for pools
    
    contract_selection dialog was expecting datetime objects
    that it was passing to a CellRendererDate, but was getting
    strings of is8601 dates instead, so convert those strings
    to datetime. Also, the model was expecting strings, change
    to gobject.TYPE_PYOBJECT
    
    (merge)


commit 7e0194549730ba1e5c26f7b6ee3a41225eef3320
Author: Adrian Likins <alikins>
Date:   Thu Jun 9 10:06:01 2011 -0400

    702029: Don't show -1 for unlimited in contact_selection
    
    Part of this fix was already there, this should be the last
    bits.


(both commits are needed to fix it, they are intertwined)
Comment 5 John Sefler 2011-06-10 14:46:20 UTC 
Created attachment 504132 [details]
start/end dates are now displayed in the contract selection dialog

Verifying Version...
[root@jsefler-stage-6server tmp]# rpm -qa | grep subscription-manager
subscription-manager-firstboot-0.95.15-1.git.0.a616959.el6.x86_64
subscription-manager-gnome-0.95.15-1.git.0.a616959.el6.x86_64
subscription-manager-0.95.15-1.git.0.a616959.el6.x86_64
Comment 6 John Sefler 2011-06-10 15:01:15 UTC 
Created attachment 504140 [details]
also verifying merged fix from 702029

Since comment 3 indicates that a fix from bug 702029 was also needed to fix this bug, then let's verify that fix here in this build of subscription manager too...

[root@jsefler-stage-6server ~]# rpm -qa | grep subscription-manager
subscription-manager-firstboot-0.95.15-1.git.0.a616959.el6.x86_64
subscription-manager-gnome-0.95.15-1.git.0.a616959.el6.x86_64
subscription-manager-0.95.15-1.git.0.a616959.el6.x86_64

[root@jsefler-stage-6server ~]# subscription-manager register --username=testuser1 --password=password --type=person
f6f97586-71a2-474c-a28a-1834aaecf56a testuser1
[root@jsefler-stage-6server ~]# subscription-manager list --avail
+-------------------------------------------+
    Available Subscriptions
+-------------------------------------------+


ProductName:       	Awesome OS Developer Edition
ProductId:         	AWESOMEOS09XYU34         
PoolId:            	8a90f8b4307292fe01307293c34101d2
Quantity:          	10                       
Expires:           	06/07/2012               


ProductName:       	Awesome OS Developer Edition
ProductId:         	AWESOMEOS09XYU34         
PoolId:            	8a90f8b4307292fe01307293c35501d4
Quantity:          	5                        
Expires:           	06/07/2012               

[root@jsefler-stage-6server ~]# subscription-manager subscribe --pool=8a90f8b4307292fe01307293c35501d4
[root@jsefler-stage-6server ~]# subscription-manager clean
All local data removed
[root@jsefler-stage-6server ~]# subscription-manager register --username=testuser1 --password=password --type=system
c30c2d89-f931-4a72-8a5a-c6d27a695021 jsefler-stage-6server.usersys.redhat.com
[root@jsefler-stage-6server ~]# subscription-manager-gui&
[1] 1276

VERIFIED - the fix for -1/unlimited available subscriptions is also included in this build of subscription-manager
Comment 7 Tomas Capek 2011-06-24 08:55:26 UTC 
    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
Previously, the "Start Date" and "End Date" fields in the Contract Selection dialog window of the subscription-manager-gui utility were not populated. With this update, the dates are displayed as expected.
Comment 8 errata-xmlrpc 2011-12-06 17:14:06 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHBA-2011-1695.html