Bug 703995

Created attachment 498387 [details]
Patch

Test this bug on 5.6-11. it is not fixed enough, the /etc/cron.d/ovirt-logrotate set is incorrect with /etc/logrotate.d/ovirt-logrotate.conf setting.

1. vi #/etc/logrotate.d/ovirt-node
/var/log/ovirt*.log /var/log/mcelog /var/log/brcm-iscsi.log {
    rotate 3
    compress
    missingok
    size 1M
    create
}
2. #ll /etc/logrotate.d/ 
total 36
-rw-r--r-- 1 root root 144 Dec 17  2009 acpid
-rw-r--r-- 1 root root 163 Apr 19 11:05 libvirtd
-rw-r--r-- 1 root root 127 May 17 07:48 ovirt-node
-rw-r--r-- 1 root root  61 Nov 17 07:25 rpm
-rw-r--r-- 1 root root 154 Apr 28  2010 snmpd
-rw-r--r-- 1 root root 306 Jan 22  2008 syslog
-rw-r--r-- 1 root root  32 Nov 13  2007 up2date
-rw-r--r-- 1 root root 173 Jan 24  2010 vdsm
-rw-r--r-- 1 root root 157 Oct 31  2009 vdsm-reg

3.# cat /etc/cron.d/ovirt-logrotate 
# Run each log rotation every 10 minutes
*/10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/ovirt-logrotate.conf
*/10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/syslog

Actual result:
in /etc/cron.d/ovirt-logrotate file, there should set ovirt-node for cron, but not ovirt-logrotate.conf. under /etc/logrotate.d/, there is no ovirt-logrotate.conf.

expected result:
in /etc/cron.d/ovirt-logrotate file, it should set 
*/10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/ovirt-node

Created attachment 499344 [details]
Follow-up patch

Verified this bug on rhevh 5.6-11.1 build. 

The /var/log/brcm-iscsi.log can be rotated when its size > 1M.

# cat /etc/logrotate.d/ovirt-node 
/var/log/ovirt*.log /var/log/mcelog /var/log/brcm-iscsi.log {
    rotate 3
    compress
    missingok
    size 1M
    create
}
# cat /etc/cron.d/ovirt-logrotate 
# Run each log rotation every 10 minutes
*/10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/ovirt-node
*/10 * * * * root /usr/sbin/logrotate /etc/logrotate.d/syslog

Pls change the bug status to 'ON-QA', after that I will change it to 'Verified'.

Verified on rhevh 5.6-11.1 build.

    Technical note added. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    New Contents:
The brcm-iscsi.log file is not logrotated by default.  This patch enables log rotation to prevent it from growing indefinitely.
Also, a previously existing bug was discovered that prevented ovirt.log from getting rotated.  This bug was also fixed.

    Technical note updated. If any revisions are required, please edit the "Technical Notes" field
    accordingly. All revisions will be proofread by the Engineering Content Services team.
    
    Diffed Contents:
@@ -1,2 +1 @@
-The brcm-iscsi.log file is not logrotated by default.  This patch enables log rotation to prevent it from growing indefinitely.
+Prior to this update, "/var/log/brcm-iscsi.log" file was not log-rotated by default. With this update, log rotation of the "/var/log/brcm-iscsi.log" file is enabled to prevent it from growing indefinitely. Additionally, a previously existing bug was discovered that prevented the "/var/log/ovirt.log" file from being rotated. This update fixes this issue, and log rotatation for the "/var/log/ovirt.log" file works as expected.-Also, a previously existing bug was discovered that prevented ovirt.log from getting rotated.  This bug was also fixed.

An advisory has been issued which should help the problem
described in this bug report. This report is therefore being
closed with a resolution of ERRATA. For more information
on therefore solution and/or where to find the updated files,
please follow the link below. You may reopen this bug report
if the solution does not work for you.

http://rhn.redhat.com/errata/RHBA-2011-0851.html