Bug 704239

I would not add all the necessary code to support python3 in your spec as long as upstream does not support python3.

One can not predict if the project is ever going to switch to python3 and in the meanwhile it is a quite big overhead in the spec.
Keep it simple ;-)

I upload a new Spec and SRPM :

Spec URL: http://saispo.fedorapeople.org/python-yolk.spec
SRPM URL: http://saispo.fedorapeople.org/python-yolk-0.4.1-2.fc15.src.rpm

And another one :

Spec URL: http://saispo.fedorapeople.org/python-yolk.spec
SRPM URL: http://saispo.fedorapeople.org/python-yolk-0.4.1-3.fc15.src.rpm

I think it would be interesting to have the unit-test running in the spec.

Also I am not sure the example folder should actually be tag as %doc since
it contains plugins.
What's your opinion ?




[X] rpmlint must be run on every package.
   python-yolk.src: W: spelling-error %description -l en_US distutils -> disturber, disturbing, disturbed
   python-yolk.src: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, setups
   python-yolk.noarch: W: spelling-error %description -l en_US distutils -> disturber, disturbing, disturbed
   python-yolk.noarch: W: spelling-error %description -l en_US setuptools -> setup tools, setup-tools, setups
   2 packages and 0 specfiles checked; 0 errors, 4 warnings.
      Output can be safely ignored

[X] The package must be named according to the Package Naming Guidelines.

[X] The spec file name must match the base package %{name}, in the format
      %{name}.spec unless your package has an exemption.

[X] The package must meet the Packaging Guidelines.

[X] The package must be licensed with a Fedora approved license and meet the
      Licensing Guidelines.

[X] The License field in the package spec file must match the actual license.
   License is 

[X] If (and only if) the source package includes the text of the license(s)
     in its own file, then that file, containing the text of the license(s) for
     the package must be included in %doc.

[X] The spec file must be written in American English.

[X] The spec file for the package MUST be legible.

[X] The sources used to build the package must match the upstream source, as
      provided in the spec URL.
   source from the src.rpm: 
   004e7bf297ac9a752d4d41c3f7eeea7adaa7a675  yolk-0.4.1.tar.gz
   004e7bf297ac9a752d4d41c3f7eeea7adaa7a675  /home/pingou/rpmbuild/SOURCES/yolk-0.4.1.tar.gz

[X] The package MUST successfully compile and build into binary rpms on at
     least one primary architecture.
   Koji build: http://koji.fedoraproject.org/koji/taskinfo?taskID=3130579
   0 free  0 open  2 done  0 failed
   3130579 build (dist-f16, python-yolk-0.4.1-3.fc15.src.rpm) completed successfully

[NA] If the package does not successfully compile, build or work on an
      architecture, then those architectures should be listed in the spec in
      ExcludeArch.

[X] All build dependencies must be listed in BuildRequires, except for any
     that are listed in the exceptions section of the Packaging Guidelines ;
     inclusion of those as BuildRequires is optional.

[NA] The spec file MUST handle locales properly. This is done by using the
      %find_lang macro. Using %{_datadir}/locale/* is strictly forbidden.

[NA] Every binary RPM package (or subpackage) which stores shared library
      files(not just symlinks) in any of the dynamic linker's default paths,
      must call ldconfig in %post and %postun.

[NA] Packages must NOT bundle copies of system libraries.

[NA] If the package is designed to be relocatable, the packager must state
      this fact in the request for review, along with the rationalization for
      relocation of that specific package. Without this, use of Prefix: /usr is
      considered a blocker.

[X] A package must own all directories that it creates. If it does not create
     a directory that it uses, then it should require a package which does
     create that directory.

[X] A Fedora package must not list a file more than once in the spec file's
      %files listings. 

[X] Permissions on files must be set properly. Executables should be set with
     executable permissions, for example. Every %files section must include a
     %defattr(...) line.

[!] Each package must consistently use macros.
    You use %{__python} and chmod. Please be consistent here (and personnaly I would
    drop the %{__python} for python).

[X] The package must contain code, or permissable content.

[NA] Large documentation files must go in a -doc subpackage.

[X] If a package includes something as %doc, it must not affect the runtime
     of the application. To summarize: If it is in %doc, the program must run
     properly if it is not present.
  Remark: see above

[NA] Header files must be in a -devel package.

[NA] Static libraries must be in a -static package.

[NA] If a package contains library files with a suffix (e.g. libfoo.so.1.1),
      then library files that end in .so (without suffix) must go in a -devel
      package.

[NA] In the vast majority of cases, devel packages must require the base
      package using a fully versioned dependency: Requires: %{name} =
      %{version}-%{release}.

[X] Packages must NOT contain any .la libtool archives, these must be removed
      in the spec if they are built.

[NA] Packages containing GUI applications must include a %{name}.desktop file,
      and that file must be properly installed with desktop-file-install in the
      %install section.

[X] Packages must not own files or directories already owned by other
      packages.

[X] All filenames in rpm packages must be valid UTF-8.


Please address this few points* and I will approve the package.

* unit-tests, macro and %doc.

Fox examples/* i prefer to keep them into docs because it's only if you want to devel plugins and it's not useable in production env.

I fixed the remaining few points :

Spec URL: http://saispo.fedorapeople.org/python-yolk.spec
SRPM URL: http://saispo.fedorapeople.org/python-yolk-0.4.1-4.fc15.src.rpm

(In reply to comment #5)
> Fox examples/* i prefer to keep them into docs because it's only if you want > to devel plugins and it's not useable in production env.

Ok I'm fine with this.

> I fixed the remaining few points :

+ python setup.py test
running test
running egg_info
writing requirements to yolk.egg-info/requires.txt
writing yolk.egg-info/PKG-INFO
writing top-level names to yolk.egg-info/top_level.txt
writing dependency_links to yolk.egg-info/dependency_links.txt
writing entry points to yolk.egg-info/entry_points.txt
reading manifest file 'yolk.egg-info/SOURCES.txt'
writing manifest file 'yolk.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.007s

Not entirely :-)

I will send a mail upstream for more information about the test.

Any reply from upstream ?

No, not at this time and i think i'll never have a reply

As this is not a mandatory element for the package I will approve it.

However I strongly encourage you to try to contact upstream further. You are the one who will get the bug report and being in contact with upstream is important to be able to fix these bugs.
And having the unit-test running is for sure something that will make your life as packager safer.


This package is APPROVED.

New Package SCM Request
=======================
Package Name: python-yolk
Short Description: Command-line too querying PyPi and Python packages installed on your system
Owners: saispo
Branches: f14 f15 el6
InitialCC: saispo

Git done (by process-git-requests).

ping ?

Upload done for Fedora Rawhide and Fedora 16

python-yolk-0.4.1-4.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/python-yolk-0.4.1-4.fc15

python-yolk-0.4.1-4.fc14 has been submitted as an update for Fedora 14.
https://admin.fedoraproject.org/updates/python-yolk-0.4.1-4.fc14

python-yolk-0.4.1-4.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/python-yolk-0.4.1-4.fc16

python-yolk-0.4.1-4.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/python-yolk-0.4.1-4.el6

python-yolk-0.4.1-4.fc15 has been pushed to the Fedora 15 stable repository.

python-yolk-0.4.1-4.fc14 has been pushed to the Fedora 14 stable repository.

python-yolk-0.4.1-4.el6 has been pushed to the Fedora EPEL 6 stable repository.