Bug 704559

Summary: Possible problems found by static analysis of code
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: patchutilsAssignee: Tim Waugh <twaugh>
Status: CLOSED UPSTREAM QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 15CC: twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: All   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-07-16 16:34:12 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
Avoid possible null pointer access
none
Fixed suspicious sizeofs
none
Fix some possible resource leaks
none
error log none

Description Jiri Popelka 2011-05-13 15:26:27 UTC 
Description of problem:
Static analysis of the code with/without applied patches discovered
some possible problems in the code.

Version-Release number of selected component (if applicable):
patchutils-0.3.2-1.fc15
Comment 1 Jiri Popelka 2011-05-13 15:28:31 UTC 
Created attachment 498786 [details]
Avoid possible null pointer access
Comment 2 Jiri Popelka 2011-05-13 15:28:56 UTC 
Created attachment 498787 [details]
Fixed suspicious sizeofs
Comment 3 Jiri Popelka 2011-05-13 15:29:38 UTC 
Created attachment 498788 [details]
Fix some possible resource leaks

Tim, I'm not sure about some of them so please check it.
Comment 4 Jiri Popelka 2011-05-13 15:34:15 UTC 
Created attachment 498790 [details]
error log

There's one reported problem where I'm not able to decide whether it's really a problem and how to properly treat it so I'm leaving it up to you :-)
Comment 5 Tim Waugh 2011-05-20 13:02:32 UTC 
Thanks, applied upstream, with some small changes to the resource leak patch.

There was indeed a problem discovered by the log in comment #4.  I've fixed that too.