Bug 704568

Summary: Possible problems found by static analysis of code
Product: [Fedora] Fedora Reporter: Jiri Popelka <jpopelka>
Component: pnm2ppaAssignee: Tim Waugh <twaugh>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: low Docs Contact:
Priority: low    
Version: 15CC: twaugh
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: pnm2ppa-1.04-22.fc16 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-05-20 15:08:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
return_local none

Description Jiri Popelka 2011-05-13 15:49:58 UTC 
Description of problem:
Static analysis of the code with/without applied patches discovered
some possible problems in the code.


Version-Release number of selected component (if applicable):
pnm2ppa-1.04-21.fc15
Comment 1 Jiri Popelka 2011-05-13 15:50:58 UTC 
Created attachment 498797 [details]
return_local

Error: RETURN_LOCAL:
pnm2ppa-1.04/calibrate_ppa.c:162: local_ptr_assign_local: Assigning: "out_filepath" = "filepath" (address of local variable "filepath").
pnm2ppa-1.04/calibrate_ppa.c:164: out_of_scope: Variable "filepath" goes out of scope.
pnm2ppa-1.04/calibrate_ppa.c:226: use_invalid: Using "out_filepath", which points to an out-of-scope variable "filepath".

Error: RETURN_LOCAL:
pnm2ppa-1.04/pnm2ppa.c:159: local_ptr_assign_local: Assigning: "path" = "File_path" (address of local variable "File_path").
pnm2ppa-1.04/pnm2ppa.c:160: return_local_addr_alias: Returning pointer "path" which points to local variable "File_path".