Bug 704934

Summary: RFE: New volume button should work well for disk/iSCSI pool in virt-manager
Product: Red Hat Enterprise Linux 5 Reporter: Min Zhan <mzhan>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED WONTFIX QA Contact: Virtualization Bugs <virt-bugs>
Severity: medium Docs Contact:
Priority: high    
Version: 5.7CC: ccui, dyuan, llim, mshao, mzhan
Target Milestone: rcKeywords: FutureFeature
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of:
: 706827 (view as bug list) Environment:
Last Closed: 2011-07-12 23:24:06 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 706827    

Description Min Zhan 2011-05-16 03:37:45 UTC
Description of problem:
First create a disk pool in virt-manager, then click New volume, an error display

Version-Release number of selected component (if applicable):
virt-manager-0.6.1-14.el5
libvirt-0.8.2-18.el5

How reproducible:
Always

Steps to Reproduce:
1. First create a disk pool in virt-manager

# virsh pool-dumpxml disk
<pool type='disk'>
  <name>disk</name>
  <uuid>10704474-12dd-a75a-fc88-02f9edb07a91</uuid>
  <capacity>500105249280</capacity>
  <allocation>0</allocation>
  <available>500105248768</available>
  <source>
    <device path='/dev/sdb'>
    <freeExtent start='512' end='500105249280'/>
    </device>
    <format type='sun'/>
  </source>
  <target>
    <path>/dev</path>
    <permissions>
      <mode>0700</mode>
      <owner>-1</owner>
      <group>-1</group>
    </permissions>
  </target>
</pool>

2. In disk pool, click New Volume button to create a vol

  
Actual results:

An error display:
Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/host.py", line 479, in add_vol
    self.addvol = vmmCreateVolume(self.config, self.conn, pool)
  File "/usr/share/virt-manager/virtManager/createvol.py", line 59, in __init__
    self.vol_class = Storage.StoragePool.get_volume_for_pool(parent_pool.get_type())
  File "/usr/lib/python2.4/site-packages/virtinst/Storage.py", line 236, in get_volume_for_pool
    return pool_class.get_volume_class()
  File "/usr/lib/python2.4/site-packages/virtinst/Storage.py", line 585, in get_volume_class
    raise NotImplementedError(_("Disk volume creation is not implemented."))
NotImplementedError: Disk volume creation is not implemented.


Expected results:
The vol for disk pool can be created successfully

Additional info:

Comment 1 Min Zhan 2011-05-16 03:39:42 UTC
Environment supplement:
# uname -a
Linux localhost.localdomain 2.6.18-259.el5xen #1 SMP Fri Apr 29 01:19:02 EDT 2011 x86_64 x86_64 x86_64 GNU/Linux

xen-3.0.3-130.el5

Comment 2 Min Zhan 2011-05-16 05:02:48 UTC
Similar error happens when creating a volume in iscsi pool

Traceback (most recent call last):
  File "/usr/share/virt-manager/virtManager/host.py", line 482, in add_vol
    self.addvol.set_parent_pool(pool)
  File "/usr/share/virt-manager/virtManager/createvol.py", line 93, in set_parent_pool
    self.vol_class = Storage.StoragePool.get_volume_for_pool(self.parent_pool.get_type())
  File "/usr/lib/python2.4/site-packages/virtinst/Storage.py", line 236, in get_volume_for_pool
    return pool_class.get_volume_class()
  File "/usr/lib/python2.4/site-packages/virtinst/Storage.py", line 644, in get_volume_class
    raise NotImplementedError(_("iSCSI volume creation is not "
NotImplementedError: iSCSI volume creation is not implemented.

Comment 3 RHEL Program Management 2011-06-21 05:25:48 UTC
This request was evaluated by Red Hat Product Management for inclusion in Red Hat Enterprise Linux 5.7 and Red Hat does not plan to fix this issue the currently developed update.

Contact your manager or support representative in case you need to escalate this bug.

Comment 5 Cole Robinson 2011-07-12 23:24:06 UTC
Libvirt doesn't support iscsi volume creation. Libvirt does support disk volume creation, however I don't think it's worth the risk of backporting this virt-manager functionality at this point in RHEL5. Closing as WONTFIX