Bug 705101

Summary: Need to package /etc/logrotate.d/iwhd
Product: [Retired] CloudForms Cloud Engine Reporter: Pete Zaitcev <zaitcev>
Component: iwhdAssignee: Pete Zaitcev <zaitcev>
Status: CLOSED CURRENTRELEASE QA Contact: Dave Johnson <dajohnso>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 1.0.0CC: brad, dajohnso, deltacloud-maint, imcleod, markmc, morazi, ssachdev, whayutin
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-19 19:37:24 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On:    
Bug Blocks: 698373    
Attachments:
Description Flags
candidate patch 1 none

Description Pete Zaitcev 2011-05-16 16:01:09 UTC 
Description of problem:

iwhd's log file grows unbound

[root@locutus ~]# ls -l /var/log/iwhd.log 
-rw-r--r--. 1 root root 10121121543 Apr 26 16:41 /var/log/iwhd.log
[root@locutus ~]# 

Version-Release number of selected component (if applicable):

iwhd-0.92-1.p1.fc14.x86_64

How reproducible:

synchronous

Steps to Reproduce:
1. run iwhd
  
Actual results:

Logs are not rotated.

Expected results:

Logs rotated.

Additional info:
Comment 2 Pete Zaitcev 2011-07-01 22:27:07 UTC 
We need to switch to syslog, because it's impossible to rotate a raw
dump of stderr. Also, see bz#698373 for other logging improvements.
Comment 3 Pete Zaitcev 2011-07-08 03:54:13 UTC 
Switching to syslog turned out harder than it looked, because there are
libraries to consider. For now we are just going to stick to writing
to a file, just open it explicitly for the kill -HUP to work.
Comment 4 Pete Zaitcev 2011-07-08 04:22:48 UTC 
Created attachment 511839 [details]
candidate patch 1
Comment 5 Mark McLoughlin 2011-07-08 08:59:14 UTC 
Nice patch Pete.

How about a combination of your patch and this little logging API:

https://github.com/markmc/iwhd/commit/44c26d5800

That way we at least get timestamps (for #698373) from the error() and DPRINTF() calls
Comment 6 Pete Zaitcev 2011-07-16 00:10:51 UTC 
https://fedorahosted.org/pipermail/iwhd-devel/2011-July/000738.html
Comment 7 wes hayutin 2011-09-28 16:41:57 UTC 
making sure all the bugs are at the right version for future queries
Comment 9 Brad P. Crochet 2011-11-07 18:40:38 UTC 
Verified:

[root@qeblade33 ~]# rpm -ql iwhd | grep logrotate
/etc/logrotate.d/iwhd


[root@qeblade33 ~]# rpm -q iwhd 
iwhd-0.991-1.el6.x86_64