Bug 705133
Summary: | Review Request: btparser - Parser and analyzer for backtraces produced by GDB | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Karel Klíč <kklic> |
Component: | Package Review | Assignee: | Jiri Moskovcak <jmoskovc> |
Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | dfediuck, fedora-package-review, jmoskovc, notting, rvokal |
Target Milestone: | --- | Flags: | jmoskovc:
fedora-review+
j: fedora-cvs+ |
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | btparser-0.13-1.fc15 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2011-06-21 17:19:34 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Karel Klíč
2011-05-16 18:35:46 UTC
OK source files match upstream: ca445ed4d8e40b75b8144dfe9bd66d3c6e0109c8 btparser-0.13.tar.xz ca445ed4d8e40b75b8144dfe9bd66d3c6e0109c8 btparser-local.tar.xz OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK license field matches the actual license - GPLv2+ OK license is open source-compatible. License text included in package - GPLv2+ OK latest version is being packaged. OK BuildRequires are proper. OK compiler flags are appropriate. OK package builds in mock (F15). OK debuginfo package looks complete. OK rpmlint is silent. (just some false positives) $ rpmlint SPECS/btparser.spec RPMS/x86_64/btparser-0.13-1.fc15.x86_64.rpm btparser.x86_64: W: spelling-error Summary(en_US) backtraces -> backtracks, back traces, back-traces btparser.x86_64: W: spelling-error %description -l en_US backtrace -> backtrack, back trace, back-trace btparser.x86_64: W: spelling-error %description -l en_US backtraces -> backtracks, back traces, back-traces btparser.x86_64: W: shared-lib-calls-exit /usr/lib64/libbtparser.so.2.2.2 exit.5 -> explained in previous comment 1 packages and 1 specfiles checked; 0 errors, 4 warnings. OK final provides and requires look sane. OK %check is present and all tests pass. OK shared libraries are added to the regular linker search paths with proper scriptlets BAD owns the directories it creates. - %{_bindir}/%{name} + %dir %{_bindir}/%{name} OK doesn't own any directories it shouldn't. OK no duplicates in %files. OK file permissions are appropriate. OK correct scriptlets present. N/A documentation is small, so no -docs subpackage is necessary. OK %docs are not necessary for the proper functioning of the package. - but packaging some offline reference manual would be nice OK headers in -devel OK pkgconfig files in -devel OK no libtool .la droppings. - if you fix the %dir comment then I'm fine with it My bad, it's not a directory. The rest seems ok. New Package SCM Request ======================= Package Name: btparser Short Description: Parser and analyzer for backtraces produced by GDB Owners: kklic jmoskovc Branches: InitialCC: New Package SCM Request ======================= Package Name: btparser Short Description: Parser and analyzer for backtraces produced by GDB Owners: kklic jmoskovc Branches: f15 InitialCC: This ticket is not assigned to anyone. It should be assigned to the reviewer. Please fix and re-raise the fedora-cvs flag. Git done (by process-git-requests). btparser-0.13-1.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/btparser-0.13-1.fc15 btparser-0.13-1.fc15 has been pushed to the Fedora 15 testing repository. btparser-0.13-1.fc15 has been pushed to the Fedora 15 stable repository. |