Bug 705161

Summary:	virtio_pci actually required, but not depended on by virtio_blk module
Product:	Red Hat Enterprise Linux 5	Reporter:	joshua
Component:	mkinitrd	Assignee:	Brian Lane <bcl>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Release Test Team <release-test-team>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	5.6	CC:	areis, ddumas, gchakkar, rhod
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2012-06-06 20:40:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description joshua 2011-05-16 20:17:51 UTC

When converting a VM over to use virtio recently,  had to change modprobe.conf
to reference virtio_blk and virtio_net, and remake the initrd.

When running mkinitrd with verbose output, I noticed that virtio_blk,
virtio_pci, virtio_ring, and virtio where referenced as being included in the
initrd.

A reboot doesn't work, as the kernel can't find its own root disk.
I rescued the system, and remade the initrd with exactly the same command as
before, the one addition:  --with=virtio_pci

This works!

The problem is shown by "modinfo virtio_blk".  Notice that virtio_pci isn't
listed as a dependency... even though it is actually required to work properly.
Can we get this fixed so that mkinitrd doesn't unknowingly create incomplete
initrds ?

Comment 1 Ronen Hod 2012-05-06 17:14:16 UTC

Joshua,

Thank you for taking the time to enter a bug report with us. We do appreciate the feedback and look to use reports such as this to guide our efforts at improving our products. That being said, this bug tracking system is not a mechanism for getting support, and as such we are not able to make any guarantees as to the timeliness or suitability of a resolution.
 
If this issue is critical or in any way time sensitive, please raise a ticket through your regular Red Hat support channels to make certain that it gets the proper attention and prioritization to assure a timely resolution. 
 
For information on how to contact the Red Hat production support team, please see:
https://www.redhat.com/support/process/production/#howto

In any case, this seems like a real bug, but since it has a workaround, and this is the only report about this scenario, and RHEL5.9 GA is only in Dec 2012, I would like to close this bug.

Thanks, Ronen.

Comment 2 joshua 2012-05-07 14:36:13 UTC

So it *is* a real bug, but you just don't care to fix it?

The fix is very trivial, should take about 10 minutes or so to fix.  Red Hat could easily make this happen in time for the December target of RHEL 5.9

Comment 3 Ronen Hod 2012-05-07 19:08:49 UTC

QE,

Can you please verify that the issue does not exist in RHEL6.3.

Thanks, Ronen.

Comment 6 Eduardo Habkost 2012-06-06 13:54:19 UTC

Joshua, what's the mkinitrd version you are using? This bug was fixed on RHEL-5.5, on mkinitrd-5.1.19.6-58. See Bug 560672.

Comment 7 Eduardo Habkost 2012-06-06 14:22:36 UTC

(In reply to comment #3)
> QE,
> 
> Can you please verify that the issue does not exist in RHEL6.3.

I have just tested mkinitrd on a RHEL-6 system, and it pulls virtio_pci properly (well, it had to, otherwise my RHEL-6 guest would never have booted properly).

Comment 9 Brian Lane 2012-06-06 16:30:31 UTC

Please include the version of mkinitrd you are using, run:
rpm -q mkinitrd

Also, please run this and attach the output as a text/plain file to this bug:

bash -x mkinitrd -v -f initrd-$(uname -r).img $(uname -r)

Comment 10 joshua 2012-06-06 18:56:00 UTC

I create this Bug entry over a year ago.  I no longer have access to that VM, and even if I did the mkinitrd system has been upgraded several times since then.

What I was after was assurances that the problem had been fixed in RHEL 5 and 6.
Sounds like both versions have been fixed.