Bug 705340

Summary: virt-manager: 'copy host cpu information' does not copy its flags
Product: [Fedora] Fedora Reporter: Yaniv Kaul <ykaul>
Component: virt-managerAssignee: Cole Robinson <crobinso>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: unspecified    
Version: 15CC: berrange, crobinso, hbrock, jforbes, jkt, virt-maint
Target Milestone: ---Keywords: Reopened
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: virt-manager-0.9.1-1.fc15 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2012-02-14 08:57:34 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
log
none
XML from virsh dumpxml none

Description Yaniv Kaul 2011-05-17 12:23:59 UTC 
Description of problem:
My CPU:
Intel(R) Core(TM)2 Duo CPU     T9600  @ 2.80GHz
flags           : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts acpi mmx fxsr sse sse2 ss ht tm pbe syscall nx lm constant_tsc arch_perfmon pebs bts rep_good nopl aperfmperf pni dtes64 monitor ds_cpl vmx smx est tm2 ssse3 cx16 xtpr pdcm sse4_1 lahf_lm dts tpr_shadow vnmi flexpriority


Yet when clicking on 'copy host CPU information', I'm not getting many of these flags. Specifically, I miss the SSE* flags which actually do something.

Version-Release number of selected component (if applicable):
libvirt-client-0.8.8-4.fc15.x86_64
libvirt-python-0.8.8-4.fc15.x86_64
libvirt-0.8.8-4.fc15.x86_64
virt-manager-0.8.7-4.fc15.noarch

How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:
Comment 1 Cole Robinson 2011-07-11 16:40:21 UTC 
How are you verifying that these flags aren't copied?

The way this works in virt-manager is that we specify to qemu the -cpu model that covers the largest subset of your host CPU flags, then only manually copy over +flags that are not associated with that model, but which your host exposes.

I'm pretty sure we are doing the correct thing here, so closing NOTABUG. If you still think there is an issue, please provide

virsh dumpxml $vmname (as root)
/var/log/libvirt/qemu/$vmname.log
Comment 2 Yaniv Kaul 2011-07-12 12:01:32 UTC 
Created attachment 512404 [details]
log
Comment 3 Yaniv Kaul 2011-07-12 12:02:15 UTC 
Created attachment 512405 [details]
XML from virsh dumpxml
Comment 4 Yaniv Kaul 2011-07-12 12:09:51 UTC 
You are partially correct. I see the flags in the guest - but they are NOT checked in the 'CPU Features' list. So  I suspect a GUI bug (although I don't see it in the XML neither, I suspect it's 'inherited' from the CPU definition.).
Comment 5 Cole Robinson 2011-07-13 18:35:59 UTC 
Okay, thanks for following up, fixed upstream now:

http://git.fedorahosted.org/git?p=virt-manager.git;a=commit;h=cbaedd87bcfd44c3a8bdf99891c31ec9f41e3d0b

The CPU feature list now shows a bit more info about the flags passed to the guest. Flags marked as 'model' mean they are implied by the choice of CPU model. At the libvirt level, flags implied by a CPU model choice do not show up in the XML.
Comment 6 Fedora Update System 2012-02-01 18:24:56 UTC 
virt-manager-0.9.1-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/virt-manager-0.9.1-1.fc15
Comment 7 Fedora Update System 2012-02-02 17:24:15 UTC 
Package virt-manager-0.9.1-1.fc15:
* should fix your issue,
* was pushed to the Fedora 15 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing virt-manager-0.9.1-1.fc15'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2012-1173/virt-manager-0.9.1-1.fc15
then log in and leave karma (feedback).
Comment 8 Fedora Update System 2012-02-14 08:57:34 UTC 
virt-manager-0.9.1-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.