Bug 705713
| Summary: | Templates not honored for resource-config when creating a new resource | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Other] RHQ Project | Reporter: | Heiko W. Rupp <hrupp> | ||||||
| Component: | Core UI | Assignee: | Charles Crouch <ccrouch> | ||||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Mike Foley <mfoley> | ||||||
| Severity: | high | Docs Contact: | |||||||
| Priority: | high | ||||||||
| Version: | 4.0.0 | CC: | ccrouch, hbrock, hrupp, jshaughn, skondkar | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2013-09-03 17:00:35 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 678340, 705059, 715334, 729848, 730796 | ||||||||
| Attachments: |
|
||||||||
Created attachment 499543 [details]
step 2
I think the issue may be here: org.rhq.enterprise.gui.coregui.client.inventory.resource.factory.AbstractResourceFactoryWizard#setNewResourceConfigurationDefinition As this is always using the default template and not the one the user selected in the step before .. = this.newResourceConfigurationDefinition.getDefaultTemplate()... [15:34:59] <jshaughn> well, there is a bug, minimally with previous/next behavior [15:37:05] <jshaughn> but the workaround would be cancel and reinvoke the wizard. [15:39:59] <pilhuhn> I have [15:40:09] <pilhuhn> <resource-configuration> [15:40:09] <pilhuhn> <c:simple-property name="profile" description="The profile name" required="true"/> [15:40:10] <pilhuhn> ... [15:40:20] <pilhuhn> <c:template name="foo" description="just a demo"> [15:40:20] <pilhuhn> <c:simple-property name="bla bla"/> [15:40:20] <pilhuhn> <c:simple-property name="hulla"/> [15:40:20] <pilhuhn> </c:template> [15:40:20] <pilhuhn> </resource-configuration> [15:41:06] <jshaughn> fyi: I'm testing with the RHQ Server DataSource type [15:41:09] <pilhuhn> THis nicely shows "default" and "foo" in the dropdown. When I select 'foo', in the next step the default properties are shown and not the ones from "foo" [15:41:24] <pilhuhn> that is for create child resources [15:42:50] <jshaughn> can you try DataSource and see what you see. Because that is not what I'm seeing. If I select XA I do see XA seeded in the config editor [15:45:02] <pilhuhn> Indeed [15:45:57] <pilhuhn> - the RHQ code fails silently with my stuff without telling [15:47:01] <jshaughn> really, so a silent failure of a plugin metadata issue? [15:47:36] <pilhuhn> the way I do it is accepted by the plugin and UI [15:48:11] <pilhuhn> I see that the default properties in Datasources are all grouped. I only have ungrouped ones - that may be the difference Is this still blocking you Heiko? No, not directly - this BZ itself is probably even invalid as I was misunderstanding the templates Nevertheless: - Jay wanted to fix a minor issue: back/next issue he found - Ian wanted to enable making read-only properties writable when used in CreateChild dialogs The latter would probably the solution to the issue I am running in the as7 plugin. Jay, can you comment on whether the issue Heiko is referrring to is fixed. If not, please raise a BZ Ian, can you comment on whether the issue Heiko is referrring to is fixed. If not, please raise a BZ The bug you ask about is not fixed. I've added a link to the new BZ, 729994, which I've initially set to medium/medium and not blocking anything. The BZ I created related to this, 729994 [Create/Import wizard does not allow reselection of template], has been set to ON_QA. I'm not sure if there is more work to be done on this original BZ. I'm not sure where things stand related to the read-only property work mentioned above. Asking ian to take a look and take over if necessary. [master ff5bb9e] - always make all properties, even read-only ones, writable in the config editors in the create-resource and import-resource wizards Verified on build#344 (Version: 4.1.0-SNAPSHOT Build Number: bdc6f5e) Verified on import and create child wizards. All the properties are writable. Marking as verified. Bulk closing of old issues that are in VERIFIED state. |
Created attachment 499542 [details] step 1 Have the following in a plugin descriptor: <resource-configuration> <c:list-property name="entries" required="false" readOnly="true" description="The jndi names the queue will be bound to."> <c:simple-property name="entries" type="string"/> </c:list-property> <c:template name="add" description="Template when adding a Topic"> <!--<c:list-property name="entries" required="false"--> <!--description="The jndi names the queue will be bound to.">--> <c:simple-property name="entries" type="string"/> <c:simple-property name="foobar" required="false" /> <!--</c:list-property>--> </c:template> </resource-configuration> This is some property and then a template with the name "add". I can select the template in the 1st step of the wizard, but the 2nd step seems to always display the 'default template' ( the section of the config outside the 'c:template' tag).