| Summary: | Review request: retrace-server - Application for remote coredump analysis | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Michal Toman <mtoman> |
| Component: | Package Review | Assignee: | Ondrej Vasik <ovasik> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | fedora-package-review, jmoskovc, notting, ovasik, pknirsch, rvokal |
| Target Milestone: | --- | Flags: | ovasik:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-08-25 15:21:56 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Michal Toman
2011-05-18 11:20:33 UTC
Checked srpm:
$ sha256sum retrace-server-1.0-1.fc15.src.rpm
a9e53fe5651227206cd101c77dff268ee94102d3ac767d9612954df58dbe4c82 retrace-server-1.0-1.fc15.src.rpm
YES source files match upstream:
$ sha256sum retrace-server-1.0.tar.gz retrace-server-1.0.tar.gz.1
eecdf3dc7995b5d103d8b10845f3ef7e98f6a49aa54e474037ad8dee13832dea retrace-server-1.0.tar.gz
eecdf3dc7995b5d103d8b10845f3ef7e98f6a49aa54e474037ad8dee13832dea retrace-server-1.0.tar.gz.1
YES package meets naming and versioning guidelines.
YES specfile is properly named, is cleanly written and uses macros
consistently.
YES dist tag is present.
INFO clean section and buildroot not present - but that's ok now
YES license field matches the actual license.
YES license is open source-compatible
YES License text included in package.
YES latest version is being packaged.
YES BuildRequires are proper.
YES compiler flags are appropriate.
YES package builds in mock (Rawhide/x86_64).
YES debuginfo package looks complete.
NO rpmlint is silent.
Output already posted in description, confirmed. Manual pages would be nice to have, but at the moment in the "release early, release often" stage ... I hope this will improve in future. At lease info documentation is present.
YES final provides and requires look sane.
N/A %check is present and all tests pass.
YES no shared libraries are added to the regular linker search paths.
YES owns the directories it creates.
YES doesn't own any directories it shouldn't.
YES no duplicates in %files.
YES scriptlets must be sane.
YES code, not content.
N/A large documentation files must go in a -doc subpackage.
YES %docs are not necessary for the proper functioning of the package.
YES no headers.
YES no pkgconfig files.
YES no libtool .la droppings.
YES not a GUI app.
Few comments:
%{?el6:Requires: python-argparse} ... is this really only for el6? If so, it probably could be dropped in Fedora, otherwise it should probably be extended to rhel conditional.
You have requested retrace account in https://bugzilla.redhat.com/show_bug.cgi?id=706012 ... it is no longer required?
None of these comments is blocking the approval -> APPROVED.
There is no python-argparse package in Fedora - it's a part of Python 2.7 The retrace account is used in upstream and will be a part of next release. Ok, thanks for info... New Package SCM Request ======================= Package Name: retrace-server Short Description: Application for remote coredump analysis Owners: mtoman kklic jmoskovc Branches: f15 InitialCC: Git done (by process-git-requests). Upstream updated to 1.1 Spec URL: http://mtoman.fedorapeople.org/retrace-server.spec SRPM URL: http://mtoman.fedorapeople.org/retrace-server-1.1-2.fc15.src.rpm $ rpmlint retrace-server.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. $ rpmlint retrace-server-1.1-2.fc15.src.rpm retrace-server.src: W: spelling-error Summary(en_US) coredump -> core dump, core-dump, cored ump retrace-server.src: W: spelling-error %description -l en_US coredump -> core dump, core-dump, cored ump retrace-server.src: W: spelling-error %description -l en_US backtrace -> backtrack, back trace, back-trace 1 packages and 0 specfiles checked; 0 errors, 3 warnings. $ rpmlint retrace-server-1.1-2.fc15.x86_64.rpm retrace-server.x86_64: W: spelling-error Summary(en_US) coredump -> core dump, core-dump, cored ump retrace-server.x86_64: W: spelling-error %description -l en_US coredump -> core dump, core-dump, cored ump retrace-server.x86_64: W: spelling-error %description -l en_US backtrace -> backtrack, back trace, back-trace retrace-server.x86_64: W: non-standard-uid /var/spool/retrace-server retrace retrace-server.x86_64: E: non-standard-dir-perm /var/spool/retrace-server 0775L retrace-server.x86_64: W: non-standard-uid /var/log/retrace-server retrace retrace-server.x86_64: W: non-standard-gid /var/log/retrace-server retrace retrace-server.x86_64: W: non-standard-uid /var/cache/retrace-server retrace retrace-server.x86_64: W: non-standard-gid /var/cache/retrace-server retrace retrace-server.x86_64: W: no-manual-page-for-binary coredump2packages 1 packages and 0 specfiles checked; 1 errors, 9 warnings. retrace uid/gid reserved in 706012 /var/spool/retrace-server needs to be rwx for both apache and retrace $ rpmlint retrace-server-debuginfo-1.1-2.fc15.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Package Change Request ====================== Package Name: retrace-server New Branches: el6 Owners: mtoman kklic jmoskovc Git done (by process-git-requests). Based on http://koji.fedoraproject.org/koji/packageinfo?packageID=12042 closing CURRENTRELEASE ... |