Bug 706562

Summary:	Bookmarks handling in sidebar is completely broken - need to rewrite?
Product:	[Fedora] Fedora	Reporter:	Raphael Groner <projects.rg>
Component:	midori	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	kevin, maxamillion
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-21 14:31:03 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Raphael Groner 2011-05-21 00:42:04 UTC

Description of problem:
There are previously deleted bookmarks appearing again, as well as untouched bookmarks do disappear when other bookmarks were deleted.

Version-Release number of selected component (if applicable):
midori-0.3.6-1.fc14.x86_64
- and all other and older midori upstream versions

How reproducible:
always

Steps to Reproduce:
A)
1. import some bookmarks from html
2. delete the import again
3. import several times
  
B)
1. create some bookmarks with the same name in different subfolders
2. delete one of the created bookmarks
3. restart Midori

Actual results:
A) Twice or more times same boomarks and folders in sidebar.
B) All bookmarks with the same name are gone.

Expected results:
Deleted bookmarks should stay as deleted (removed from backend or database as well). Deleting one bookmark must not affect other bookmarks.

Additional info:
Midori restarts do not change anything on the described behaviour.

- I am thinking of rewriting the whole bookmarks logic because the current implementation does not make sense to me at all. -

Comment 1 Kevin Fenzi 2011-05-21 14:09:04 UTC

> I am thinking of rewriting the whole bookmarks logic because the current
> implementation does not make sense to me at all.

I'm sure upstream would love the help. Bookmarks import is a new area and has many bugs (as you have run into). 

I can report your issues upstream, or if you are just going to start working on that, perhaps we should close this bug and you can get things fixed upstream directly?

Comment 2 Raphael Groner 2011-05-21 14:31:03 UTC

I looked through the source for handling the bookmarks. It is not as easy as I hoped. We would have to rewrite it from scratch, but I do not have the time to do that.

My next idea is to use some sort of an user script or implement a small extension that can do read-only direct access to places.sqlite of Firefox. Maybe that's a quicker work-around and a much cleaner solution.

Feel free to report my issues with the bookmarks import to upstream. :) Though, I did not test export, it should stay logically compatible when there are any changes happening to both source parts.