| Summary: | Review Request: perl-Test-Pod-Content - Test a Pod's content | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Emmanuel Seyman <emmanuel> |
| Component: | Package Review | Assignee: | Iain Arnell <iarnell> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, rc040203 |
| Target Milestone: | --- | Flags: | iarnell:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | perl-Test-Pod-Content-0.0.5-2.fc15 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-21 17:29:47 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
|
Description
Emmanuel Seyman
2011-05-22 12:20:33 UTC
When building this package for fedora < 15, rpm misses these deps:
R: perl(Pod::Simple)
R: perl(Test::More)
I'd recommend (not required) to activate the Author tests:
+ ./Build test
t/096_characters.t .... skipped: Author test. Set $ENV{RELEASE_TESTING} to a true value to run.
t/097_kwalitee.t ...... skipped: Author test. Set $ENV{RELEASE_TESTING} to a true value to run.
t/098_pod.t ........... skipped: Author test. Set $ENV{RELEASE_TESTING} to a true value to run.
t/099_pod_coverage.t .. skipped: Author test. Set $ENV{RELEASE_TESTING} to a true value to run.
I'm not at all concerned about the author tests, but Ralf is correct about missing deps if building for f14. APPROVED. koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3120281 Spec looks sane, clean and consistent; license is correct (GPL+ or Artistic); make test passes cleanly. Source tarballs match upstream (sha1sum): 1062f39845f15a956cee520498a1108c025d7c19 Test-Pod-Content-0.0.5.tar.gz 1062f39845f15a956cee520498a1108c025d7c19 Test-Pod-Content-0.0.5.tar.gz.srpm Final provides / requires are sane: ======> perl-Test-Pod-Content-0.0.5-1.fc16.noarch.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides perl(Test::Pod::Content) perl-Test-Pod-Content = 0.0.5-1.fc16 ====> requires perl(base) perl(Exporter) perl(:MODULE_COMPAT_5.12.3) perl(Pod::Simple) perl(strict) perl(Test::More) perl(version) perl(warnings) ====> obsoletes ====> conflicts ======> perl-Test-Pod-Content-0.0.5-1.fc16.src.rpm <====== ====> rpmlint 1 packages and 0 specfiles checked; 0 errors, 0 warnings. ====> provides ====> requires perl(Module::Build) perl(Pod::Simple) perl(Test::More) perl(Test::Perl::Critic) perl(version) ====> obsoletes ====> conflicts ====> mock install INFO: mock.py version 1.1.10 starting... State Changed: init plugins INFO: selinux enabled State Changed: start Mock Version: 1.1.10 INFO: Mock Version: 1.1.10 State Changed: lock buildroot INFO: installing package(s): perl-Test-Pod-Content-0.0.5-1.fc16.noarch.rpm INFO: ================================================================================ Package Arch Version Repository Size ================================================================================ Installing: perl-Test-Pod-Content noarch 0.0.5-1.fc16 /perl-Test-Pod-Content-0.0.5-1.fc16.noarch 12 k Installing for dependencies: perl-CPAN noarch 1.9402-160.fc16 fedora 246 k perl-Digest-SHA x86_64 1:5.47-160.fc16 fedora 63 k perl-ExtUtils-MakeMaker noarch 6.56-160.fc16 fedora 289 k perl-ExtUtils-ParseXS noarch 1:2.2206-160.fc16 fedora 44 k perl-Test-Harness noarch 3.17-160.fc16 fedora 239 k perl-Test-Simple noarch 0.98-1.fc16 fedora 117 k perl-devel x86_64 4:5.12.3-160.fc16 fedora 449 k perl-version x86_64 3:0.88-3.fc16 fedora 66 k python x86_64 2.7.1-8.fc16 fedora 72 k systemtap-sdt-devel x86_64 1.5-2.fc16 fedora 44 k Transaction Summary ================================================================================ Install 11 Package(s) Total size: 1.6 M Installed size: 4.3 M Installed: perl-Test-Pod-Content.noarch 0:0.0.5-1.fc16 Dependency Installed: perl-CPAN.noarch 0:1.9402-160.fc16 perl-Digest-SHA.x86_64 1:5.47-160.fc16 perl-ExtUtils-MakeMaker.noarch 0:6.56-160.fc16 perl-ExtUtils-ParseXS.noarch 1:2.2206-160.fc16 perl-Test-Harness.noarch 0:3.17-160.fc16 perl-Test-Simple.noarch 0:0.98-1.fc16 perl-devel.x86_64 4:5.12.3-160.fc16 perl-version.x86_64 3:0.88-3.fc16 python.x86_64 0:2.7.1-8.fc16 systemtap-sdt-devel.x86_64 0:1.5-2.fc16 State Changed: unlock buildroot State Changed: end (In reply to comment #2) > I'm not at all concerned about the author tests, but Ralf is correct about > missing deps if building for f14. IMO, we should exercise all tests if possible, because these often provide insights into the general quality of a package and because such tests also often expose bugs in other parts of Fedora. For example, in recent times, I have been facing bugs in perl's aspell/hunspell integration, which so far only have been exposed in AUTHOR checks in other packages. (In reply to comment #3) > (In reply to comment #2) > > I'm not at all concerned about the author tests, but Ralf is correct about > > missing deps if building for f14. > > IMO, we should exercise all tests if possible, because these often provide > insights into the general quality of a package and because such tests also > often expose bugs in other parts of Fedora. Sure, author tests are often nice to have, but as you mentioned earlier, not required for the review. If Emmanuel wants to enable them, it's his call. (In reply to comment #2) > > I'm not at all concerned about the author tests, but Ralf is correct about > missing deps if building for f14. Given that this is a dep for perl-Test-ConsistentVersion, itself a dep I need to update perl-CGI-Application-Plugin-Authentication in rawhide, I'll just release it for F15 and rawhide. > APPROVED. \o/ Thanks for the review, Iain. (In reply to comment #3) > > For example, in recent times, I have been facing bugs in perl's aspell/hunspell > integration, which so far only have been exposed in AUTHOR checks in other > packages. Ah, I didn't think something like this could happen. I'll activate the tests before import. Thanks for pointing that out. New Package SCM Request ======================= Package Name: perl-Test-Pod-Content Short Description: Test a Pod's content Owners: eseyman Branches: f15 InitialCC: perl-sig Git done (by process-git-requests). perl-Test-Pod-Content-0.0.5-2.fc15 has been submitted as an update for Fedora 15. https://admin.fedoraproject.org/updates/perl-Test-Pod-Content-0.0.5-2.fc15 perl-Test-Pod-Content-0.0.5-2.fc15 has been pushed to the Fedora 15 testing repository. perl-Test-Pod-Content-0.0.5-2.fc15 has been pushed to the Fedora 15 stable repository. |