Bug 706847

Summary: [vdsm][Init-script] vdsmd's System v init script (stop) does not stop all vdsm processes.
Product: Red Hat Enterprise Linux 6 Reporter: David Naori <dnaori>
Component: vdsmAssignee: Erez Shinan <erez>
Status: CLOSED ERRATA QA Contact: Kiril Nesenko <knesenko>
Severity: high Docs Contact:
Priority: unspecified    
Version: 6.1CC: abaron, bazulay, danken, dfediuck, dnaori, hateya, iheim, ilvovsky, knesenko, mgoldboi, ykaul
Target Milestone: rcKeywords: Regression
Target Release: ---   
Hardware: Unspecified   
OS: Linux   
Whiteboard:
Fixed In Version: vdsm-4.9-72.el6 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2011-12-06 07:19:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description David Naori 2011-05-23 08:41:33 UTC
Description of problem:
Sometimes when stopping vdsmd- not all processes are being killed and still bounded to 54321 socket.

[root@camel-vdsb storage]# /etc/init.d/vdsmd stop
Shutting down vdsm daemon: 
vdsm watchdog stop                                         [  OK  ]
vdsm stop                                                  [  OK  ]


[root@camel-vdsb storage]# ps aux | grep vdsm
vdsm      4535  0.0  0.0 1451148 26212 ?       S<   11:18   0:00 /usr/bin/python /usr/share/vdsm//vdsm
vdsm      4538  0.0  0.0 1526928 28264 ?       S<   11:18   0:00 /usr/bin/python /usr/share/vdsm//vdsm


[root@camel-vdsb storage]# lsof -i -Pn |grep 54321
vdsm       4535    vdsm    7u  IPv4 1843887      0t0  TCP 10.35.116.2:54321 (LISTEN)
vdsm       4535    vdsm   24u  IPv4 1845174      0t0  TCP 10.35.116.2:54321->10.35.77.4:51782 (CLOSE_WAIT)
vdsm       4538    vdsm    7u  IPv4 1843887      0t0  TCP 10.35.116.2:54321 (LISTEN)
vdsm       4538    vdsm   24u  IPv4 1845174      0t0  TCP 10.35.116.2:54321->10.35.77.4:51782 (CLOSE_WAIT)

therefore its impossible to start vdsmd:
vdsm: port 54321 already bound                             [FAILED]

Version-Release number of selected component (if applicable):
vdsm-4.9-68.el6.x86_64

How reproducible:
50%

Steps to Reproduce:
1./etc/init.d/vdsmd stop
2./etc/init.d/vdsmd restart (repeat till you hit it)

Comment 2 Dan Kenigsberg 2011-05-30 14:35:27 UTC
commit 7fd0047733bbb4303e41ccb002d96d1c7bb63cca (HEAD, dk/cloexec2)
Author: Dan Kenigsberg <danken>
Date:   Mon Jan 31 18:08:34 2011 +0200

    BZ#706847 close xmlrpc socket on exec
    
    Change-Id: I15bdd80a15c55db62fba7218306788f040397415


http://gerrit.usersys.redhat.com/497

Comment 5 Kiril Nesenko 2011-06-09 13:10:39 UTC
/etc/init.d/vdsmd restart was executed 200 times successfully.  
Verified
ic122
vdsm-4.9-73.el6.x86_64

Comment 6 errata-xmlrpc 2011-12-06 07:19:04 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

http://rhn.redhat.com/errata/RHEA-2011-1782.html