Bug 707000

Summary:	'xfce4-appearance-settings' misbehaves when MALLOC_PERTURB_ is set
Product:	[Fedora] Fedora	Reporter:	Enrico Scholz <rh-bugzilla>
Component:	xfce4-settings	Assignee:	Kevin Fenzi <kevin>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	15	CC:	kevin, maxamillion
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	xfce4-settings-4.8.3-1.el6	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-10-02 18:16:49 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Enrico Scholz 2011-05-23 17:37:02 UTC

Description of problem:

there seems to be an issue with uninitialized memory which is detected by MALLOC_PERTURB_:

$ env MALLOC_PERTURB_=23 xfce4-appearance-settings
(xfce4-appearance-settings:21153): Pango-WARNING **: Invalid UTF-8 string passed to pango_layout_set_text()
...

and displayed content is broken. valgrind reports here


==20995== Invalid read of size 1
==20995==    at 0x4A06D82: strlen (mc_replace_strmem.c:282)
==20995==    by 0x3507A60251: g_strdup (in /lib64/libglib-2.0.so.0.2800.6)
==20995==    by 0x35086381CC: ??? (in /lib64/libgobject-2.0.so.0.2800.6)
==20995==    by 0x4FA6C4F: ??? (in /usr/lib64/libgtk-x11-2.0.so.0.2400.4)
==20995==    by 0x4FA7988: gtk_list_store_set_valist (in /usr/lib64/libgtk-x11-2.0.so.0.2400.4)
==20995==    by 0x4FA7A86: gtk_list_store_set (in /usr/lib64/libgtk-x11-2.0.so.0.2400.4)
==20995==    by 0x403876: ??? (in /usr/bin/xfce4-appearance-settings)
==20995==    by 0x402B4B: ??? (in /usr/bin/xfce4-appearance-settings)
==20995==    by 0x3504A2143C: (below main) (in /lib64/libc-2.13.90.so)
==20995==  Address 0xc97d873 is 67 bytes inside a block of size 4,096 free'd
==20995==    at 0x4A0556E: free (vg_replace_malloc.c:366)
==20995==    by 0x3507A49AC2: g_free (in /lib64/libglib-2.0.so.0.2800.6)
==20995==    by 0x3507A630F7: g_string_chunk_free (in /lib64/libglib-2.0.so.0.2800.6)
==20995==    by 0x3508A07723: xfce_rc_close (in /usr/lib64/libxfce4util.so.4.1.1)
==20995==    by 0x40382D: ??? (in /usr/bin/xfce4-appearance-settings)
==20995==    by 0x402B4B: ??? (in /usr/bin/xfce4-appearance-settings)
==20995==    by 0x3504A2143C: (below main) (in /lib64/libc-2.13.90.so)


Version-Release number of selected component (if applicable):

xfce4-settings-4.8.1-4.fc15.x86_64

Comment 1 Kevin Fenzi 2011-05-23 22:20:18 UTC

Filed upstream for comment.

Comment 2 Kevin Fenzi 2011-05-25 02:47:57 UTC

This is fixed upstream: 

http://git.xfce.org/xfce/xfce4-settings/commit/?id=8d40a86ce47bff03704558061c5fbf0c65290e61

I can leave this open until we push an update with the fix, or we can close this and get it in the next update from upstream. 

Or do you think this is worth patching? I expect we will see a 4.8.2 soon, so it seems not worth it to me off hand.

Comment 3 Fedora Update System 2011-09-23 16:04:15 UTC

xfce4-settings-4.8.3-1.fc16 has been submitted as an update for Fedora 16.
https://admin.fedoraproject.org/updates/xfce4-settings-4.8.3-1.fc16

Comment 4 Fedora Update System 2011-09-23 16:18:41 UTC

xfce4-settings-4.8.3-1.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/xfce4-settings-4.8.3-1.fc15

Comment 5 Fedora Update System 2011-09-23 16:31:09 UTC

xfce4-settings-4.8.3-1.el6 has been submitted as an update for Fedora EPEL 6.
https://admin.fedoraproject.org/updates/xfce4-settings-4.8.3-1.el6

Comment 6 Fedora Update System 2011-09-24 20:50:56 UTC

Package xfce4-settings-4.8.3-1.fc16:
* should fix your issue,
* was pushed to the Fedora 16 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing xfce4-settings-4.8.3-1.fc16'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/xfce4-settings-4.8.3-1.fc16
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2011-10-02 18:16:44 UTC

xfce4-settings-4.8.3-1.fc16 has been pushed to the Fedora 16 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 8 Fedora Update System 2011-10-02 23:02:53 UTC

xfce4-settings-4.8.3-1.fc15 has been pushed to the Fedora 15 stable repository.  If problems still persist, please make note of it in this bug report.

Comment 9 Fedora Update System 2011-10-11 02:02:33 UTC

xfce4-settings-4.8.3-1.el6 has been pushed to the Fedora EPEL 6 stable repository.  If problems still persist, please make note of it in this bug report.