Bug 707885

Summary:	Review Request: rubygem-bson - Ruby implementation of BSON
Product:	[Fedora] Fedora	Reporter:	Vít Ondruch <vondruch>
Component:	Package Review	Assignee:	Marcela Mašláňová <mmaslano>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-package-review, notting
Target Milestone:	---	Flags:	mmaslano: fedora-review+ j: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2011-05-30 06:45:04 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:

Description Vít Ondruch 2011-05-26 09:13:33 UTC

Spec URL: http://people.redhat.com/vondruch/rubygem-bson.spec
SRPM URL: http://people.redhat.com/vondruch/rubygem-bson-1.3.1-1.fc16.src.rpm
Description: A Ruby BSON implementation for MongoDB. For more information about
Mongo, see http://www.mongodb.org. For more information on BSON, see 
http://www.bsonspec.org.

Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3093292

Comment 1 Marcela Mašláňová 2011-05-26 11:59:12 UTC

My fist rubygem review, so be patient.

I suppose it's okay to define also other paths in 'gem install' than those stated in guidelines. -> --bindir .%{_bindir}

You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own according guidelines.

Rpmlint is complaining.
rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm 
rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz
rubygem-bson.noarch: W: no-documentation
rubygem-bson.noarch: W: no-manual-page-for-binary b2json
rubygem-bson.noarch: W: no-manual-page-for-binary j2bson

Comment 2 Vít Ondruch 2011-05-26 12:44:33 UTC

(In reply to comment #1)
> My fist rubygem review, so be patient.
> 
> I suppose it's okay to define also other paths in 'gem install' than those
> stated in guidelines. -> --bindir .%{_bindir}

This avoids struggle with moving binaries and setting execution bits etc, so it is the recommended approach.

> 
> You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own
> according guidelines.

I own %{geminstdir} which is the same I hope


> 
> Rpmlint is complaining.
> rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm 
> rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz

This is custom archive with files necessary to execute the test suite.

> rubygem-bson.noarch: W: no-documentation

Documentation is in subpackage.

> rubygem-bson.noarch: W: no-manual-page-for-binary b2json
> rubygem-bson.noarch: W: no-manual-page-for-binary j2bson

No manual pages. It is not common for rubygems to contains manual pages :/

Comment 3 Marcela Mašláňová 2011-05-26 15:39:39 UTC

(In reply to comment #2)
> (In reply to comment #1)
> > My fist rubygem review, so be patient.
> > 
> > I suppose it's okay to define also other paths in 'gem install' than those
> > stated in guidelines. -> --bindir .%{_bindir}
> 
> This avoids struggle with moving binaries and setting execution bits etc, so it
> is the recommended approach.
> 
> > 
> > You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own
> > according guidelines.
> 
> I own %{geminstdir} which is the same I hope
> 
Should be fixed in packaging guidelines.
> 
> > 
> > Rpmlint is complaining.
> > rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm 
> > rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz
> 
> This is custom archive with files necessary to execute the test suite.
> 
Ok, but it's ugly.

> > rubygem-bson.noarch: W: no-documentation
> 
> Documentation is in subpackage.
> 
> > rubygem-bson.noarch: W: no-manual-page-for-binary b2json
> > rubygem-bson.noarch: W: no-manual-page-for-binary j2bson
> 
> No manual pages. It is not common for rubygems to contains manual pages :/

resolvedeps-f16 ~/Downloads/rubygem-bson-1.3.1-1.fc16.noarch.rpm 
Binary dependencies resolvable. Ok.

APPROVED

Comment 4 Vít Ondruch 2011-05-27 09:01:06 UTC

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > My fist rubygem review, so be patient.
> > > 
> > > I suppose it's okay to define also other paths in 'gem install' than those
> > > stated in guidelines. -> --bindir .%{_bindir}
> > 
> > This avoids struggle with moving binaries and setting execution bits etc, so it
> > is the recommended approach.
> > 
> > > 
> > > You don't own: %{gemdir}/gems/%{gemname}-%{version}/ ,which you should own
> > > according guidelines.
> > 
> > I own %{geminstdir} which is the same I hope
> > 
> Should be fixed in packaging guidelines.

Agree :)

> > 
> > > 
> > > Rpmlint is complaining.
> > > rpmlint rubygem-bson-1.3.1-1.fc16.src.rpm 
> > > rubygem-bson.src: W: invalid-url Source1: bson-tests.tgz
> > 
> > This is custom archive with files necessary to execute the test suite.
> > 
> Ok, but it's ugly.

Agree. If you know some better way ...

> 
> > > rubygem-bson.noarch: W: no-documentation
> > 
> > Documentation is in subpackage.
> > 
> > > rubygem-bson.noarch: W: no-manual-page-for-binary b2json
> > > rubygem-bson.noarch: W: no-manual-page-for-binary j2bson
> > 
> > No manual pages. It is not common for rubygems to contains manual pages :/
> 
> resolvedeps-f16 ~/Downloads/rubygem-bson-1.3.1-1.fc16.noarch.rpm 
> Binary dependencies resolvable. Ok.
> 
> APPROVED

Thank you for your review.



New Package SCM Request
=======================
Package Name: rubygem-bson
Short Description: Ruby implementation of BSON
Owners: vondruch
Branches: 
InitialCC:

Comment 5 Jason Tibbitts 2011-05-27 16:34:38 UTC

Git done (by process-git-requests).