Bug 707923
| Summary: | Review Request: rubygem-net-ssh-gateway - A simple library to assist in establishing tunneled Net::SSH connections | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Vít Ondruch <vondruch> |
| Component: | Package Review | Assignee: | Marcela Mašláňová <mmaslano> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | fedora-package-review, notting, tdawson |
| Target Milestone: | --- | Flags: | mmaslano:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2011-06-07 08:40:05 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Vít Ondruch
2011-05-26 10:41:52 UTC
- rpmlint OK
- package must be named according to Guidelines OK
- spec file name must match the base package %{name} OK
- package must meet the Packaging Guidelines OK
- package must be licensed with Fedora approved license ?
- license field must match actual license ?
- text of the license in its own file must be included in %doc OK
- sources must match the upstream source OK
- package MUST successfully compile and build OK
- architecture listed in ExcludeArch MUST have a bug filed in bugzilla OK
- build dependencies must be listed in BuildRequires OK
- handle locales properly with %find_lang macro OK
- shared library files must call ldconfig in %post(un) OK
- packages must NOT bundle system libraries OK
- package must own all directories that it creates OK
- permissions on files must be set properly OK
- package must consistently use macros OK
- package must contain code, or permissable content OK
- large documentation must go in a -doc OK
- %doc must not affect the runtime of the application OK
- header files must be in a -devel package OK
- static libraries must be in a -static package OK
- library files that end in .so (without suffix) must go in a -devel OK
- devel package usually require base package OK
- packages must NOT contain any .la libtool archives OK
- GUI applications must include a %{name}.desktop file OK
- packages must not own files or directories already owned by other packages OK
License: I found LGPL in setup.rb. Why should it be MIT only?
resolvedeps-f16 ~/Downloads/rubygem-net-ssh-gateway-1.1.0-1.fc16.noarch.rpm
Binary dependencies resolvable. Ok.
(In reply to comment #1) > License: I found LGPL in setup.rb. Why should it be MIT only? I have removed setup.rb. It is actually 1) Bundled external dependency. 2) Not required dependency, since setup.rb is useful only if you get the software as tarball and you want to install it in Ruby. Spec URL: http://people.redhat.com/vondruch/rubygem-net-ssh-gateway.spec SRPM URL: http://people.redhat.com/vondruch/rubygem-net-ssh-gateway-1.1.0-2.fc16.src.rpm APPROVED Thank you for your review! New Package SCM Request ======================= Package Name: rubygem-net-ssh-gateway Short Description: A simple library to assist in establishing tunneled Net::SSH connections Owners: vondruch Branches: InitialCC: Git done (by process-git-requests). Package Change Request ====================== Package Name: rubygem-net-ssh-gateway New Branches: epel7 Owners: tdawson Git done (by process-git-requests). |