Bug 708017

Summary: [vdsm][storage]vdsm is extending volumes beyond their limitation
Product: [Retired] oVirt Reporter: Moran Goldboim <mgoldboi>
Component: vdsmAssignee: Eduardo Warszawski <ewarszaw>
Status: CLOSED WONTFIX QA Contact:
Severity: medium Docs Contact:
Priority: unspecified    
Version: unspecifiedCC: abaron, acathrow, amureini, bazulay, danken, dyasny, iheim, ilvovsky, mgoldboi, ykaul
Target Milestone: ---Keywords: FutureFeature
Target Release: 3.3.4   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard: storage
Fixed In Version: Doc Type: Enhancement
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2013-01-30 22:51:54 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Attachments:
Description Flags
hsm log
none
spm log none

Description Moran Goldboim 2011-05-26 14:48:53 UTC
Created attachment 501117 [details]
hsm log

Description of problem:
vdsm doesn't check volume limitation before extending volume of a vm.
 
virsh -r domblkinfo 121 /rhev/data-center/06b29e0f-8c22-431e-a6f1-75989a582c52/2b27b725-9063-4a27-899a-3ec8d02c1ade/images/8c7091de-f0b3-4026-81cd-3f6014839e27/ea9050e5-94b6-45ca-8445-ccfa64bd5788
Capacity:       10737418240
Allocation:     1078459904
Physical:       42949672960
Version-Release number of selected component (if applicable):

vdsm-4.9-67.el6.x86_64
How reproducible:
happened on several vms on large scale environment after lots of lvextend failures

Steps to Reproduce:
1.no clear reproducer
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Moran Goldboim 2011-05-26 14:50:32 UTC
Created attachment 501118 [details]
spm log

Comment 3 Moran Goldboim 2011-05-26 14:56:02 UTC
vm id = 1df7c00a-0566-4df7-868c-95b2942f42b3

Comment 4 Igor Lvovsky 2011-05-26 15:03:48 UTC
For sparse volumes we should avoid lvExtend beyond volume size

Comment 5 Itamar Heim 2011-05-26 15:17:17 UTC
(In reply to comment #4)
> For sparse volumes we should avoid lvExtend beyond volume size

doesn't qcow have an overhead and built-in bloading which may exceed it?

Comment 6 Dan Kenigsberg 2011-05-28 22:35:36 UTC
(In reply to comment #5)
> (In reply to comment #4)
> > For sparse volumes we should avoid lvExtend beyond volume size
> 
> doesn't qcow have an overhead and built-in bloating which may exceed it?

yes, and as far as I recall, the bloat is not strictly bounded. But qcow2 files that are twice as big as their content are probably slow and should be recreated, so it might be a good idea not to lvExtend blindly beyond (twice?) image size.

Comment 7 Ayal Baron 2011-05-29 07:31:37 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > For sparse volumes we should avoid lvExtend beyond volume size
> > 
> > doesn't qcow have an overhead and built-in bloating which may exceed it?
> 
> yes, and as far as I recall, the bloat is not strictly bounded. But qcow2 files
> that are twice as big as their content are probably slow and should be
> recreated, so it might be a good idea not to lvExtend blindly beyond (twice?)
> image size.

That's a feature (just preventing is not good.  You need to convert to raw once you reach full volume size or even before that).

Comment 8 Itamar Heim 2013-01-30 22:51:54 UTC
Closing old bugs. If this issue is still relevant/important in current version, please re-open the bug.