Bug 708528
| Summary: | fails to build without downstream patches | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 6 | Reporter: | Kamil Dudka <kdudka> | ||||||
| Component: | iscsi-initiator-utils | Assignee: | Chris Leech <cleech> | ||||||
| Status: | CLOSED WONTFIX | QA Contact: | Storage QE <storage-qe> | ||||||
| Severity: | unspecified | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 6.1 | CC: | coughlan, fge, mchristi, ovasik | ||||||
| Target Milestone: | rc | Keywords: | EasyFix, Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2017-12-06 12:37:58 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 767187, 846704 | ||||||||
| Attachments: |
|
||||||||
|
Description
Kamil Dudka
2011-05-27 21:12:56 UTC
Created attachment 501400 [details]
proposed fix
Comment on attachment 501400 [details]
proposed fix
I cannot explain why the fix worked when I was testing it, but it did not solve the problem because iscsi-initiator-utils-dont-use-static.patch depends on the iscsi-initiator-utils-sync-iscsi.patch:
DEBUG: Patch #7 (iscsi-initiator-utils-dont-use-static.patch):
DEBUG: + echo 'Patch #7 (iscsi-initiator-utils-dont-use-static.patch):'
DEBUG: + /bin/cat /builddir/build/SOURCES/iscsi-initiator-utils-dont-use-static.patch
DEBUG: + /var/spool/abrt-retrace/coverity/tmp/cov-mockbuild.LTW0Ct/pwrap/patch -s -p1 -b --suffix _RAWBUILD --fuzz=0
DEBUG: /var/spool/abrt-retrace/coverity/tmp/cov-mockbuild.LTW0Ct/pwrap/patch: applying a patch annotated by _RAWBUILD
DEBUG: 1 out of 1 hunk FAILED -- saving rejects to file usr/Makefile.rej
DEBUG: error: Bad exit status from /var/tmp/rpm-tmp.TmEkxz (%prep)
DEBUG: RPM build errors:
DEBUG: Bad exit status from /var/tmp/rpm-tmp.TmEkxz (%prep)
I will prepare a better fix.
Not fully related to this bug, but I noticed that iscsi-initiator-utils-dcb.patch creates a new file ./open-iscsi-2.0-872-rc4-bnx2i/usr/Makefile.orig. Is that intentionally? Created attachment 501992 [details]
proposed fix V2
The patch should not anyhow affect a regular build.
(In reply to comment #4) > Not fully related to this bug, but I noticed that > iscsi-initiator-utils-dcb.patch creates a new file > ./open-iscsi-2.0-872-rc4-bnx2i/usr/Makefile.orig. Is that intentionally? No. A bug. will clean that up. (In reply to comment #5) > Created attachment 501992 [details] > proposed fix V2 > > The patch should not anyhow affect a regular build. Patch looks ok. Will merge it up. Thanks. Since RHEL 6.3 External Beta has begun, and this bug remains unresolved, it has been rejected as it is not proposed as exception or blocker. Red Hat invites you to ask your support representative to propose this request, if appropriate and relevant, in the next release of Red Hat Enterprise Linux. Red Hat Enterprise Linux 6 is in the Production 3 Phase. During the Production 3 Phase, Critical impact Security Advisories (RHSAs) and selected Urgent Priority Bug Fix Advisories (RHBAs) may be released as they become available. The official life cycle policy can be reviewed here: http://redhat.com/rhel/lifecycle This issue does not meet the inclusion criteria for the Production 3 Phase and will be marked as CLOSED/WONTFIX. If this remains a critical requirement, please contact Red Hat Customer Support to request a re-evaluation of the issue, citing a clear business justification. Note that a strong business justification will be required for re-evaluation. Red Hat Customer Support can be contacted via the Red Hat Customer Portal at the following URL: https://access.redhat.com/ |