Bug 708532

http://koji.fedoraproject.org/koji/taskinfo?taskID=3096983

$ rpmlint -v *
perl-Term-Animation.noarch: I: checking
perl-Term-Animation.noarch: W: spelling-error %description -l en_US newwin -> new win, new-win, newline
perl-Term-Animation.noarch: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.5.tar.gz (timeout 10 seconds)
perl-Term-Animation.src: I: checking
perl-Term-Animation.src: W: spelling-error %description -l en_US newwin -> new win, new-win, newline
perl-Term-Animation.src: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.5.tar.gz (timeout 10 seconds)
perl-Term-Animation.src: W: strange-permission Term-Animation-2.5.tar.gz 0600L
perl-Term-Animation.src:57: W: macro-in-comment %{perl_vendorarch}
perl-Term-Animation.src:58: W: macro-in-comment %exclude
perl-Term-Animation.src:58: W: macro-in-comment %dir
perl-Term-Animation.src:58: W: macro-in-comment %{perl_vendorarch}
perl-Term-Animation.src: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.5.tar.gz (timeout 10 seconds)
perl-Term-Animation.src: W: file-size-mismatch Term-Animation-2.5.tar.gz = 19395, http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.5.tar.gz = 19506
perl-Term-Animation.spec:57: W: macro-in-comment %{perl_vendorarch}
perl-Term-Animation.spec:58: W: macro-in-comment %exclude
perl-Term-Animation.spec:58: W: macro-in-comment %dir
perl-Term-Animation.spec:58: W: macro-in-comment %{perl_vendorarch}
perl-Term-Animation.spec: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.5.tar.gz (timeout 10 seconds)
2 packages and 1 specfiles checked; 0 errors, 12 warnings.

The macro-in-comment issue can be ignored, also the "spelling error".

There are no further license infos. No COPYING, no info in the source header. Only this:

"This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself."

Does this lead automatically to GPLv2? Or is it completely your choice which license do you declare?

Hi, Mario

not my choice, the license is GPLv2

yes is a free software

waiting That I get an e-mail with information =)

(In reply to comment #3)
> not my choice, the license is GPLv2
This doesn't seem to be correct to me.

http://cpansearch.perl.org/src/KBAUCOM/Term-Animation-2.6/README tells:
"This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself."

This is the standard licensing terms many older perl-modules use. 
It is an equivalent to "GPL+ or Artistic" -- It is not an equivalent to "GPLv2".

waiting That I get an e-mail with information =)

license ==>   http://dev.perl.org/licenses/

I'll make changes

license fixes completed

Spec: http://lbazan.fedorapeople.org/perl-Term-Animation.spec
SRPM: http://lbazan.fedorapeople.org/perl-Term-Animation-2.6-2.fc15.src.rpm


Description: 
This module provides a framework to produce sprite animations using ASCII art.
Each ASCII 'sprite' is given one or more frames, and placed into the animation
as an 'animation object'. An animation object can have a callback routine that
controls the position and frame of the object.

If the constructor is passed no arguments, it assumes that it is running full
screen, and behaves accordingly. Alternatively, it can accept a curses window
(created with the Curses newwin call) as an argument, and will draw into that
window.

MUSTFIX:

* BuildRequires:  perl-Test-Simple

Perl modules should not BR: a perl-module's <package> but BR. the individual perl modules (BR: perl(...)).

* Any particular reason why "make test" is commented out?

* Clean up the %files section.

remove make test
BuildRequires: change :-)


SRPM: http://lbazan.fedorapeople.org/perl-Term-Animation-2.6-5.fc15.src.rpm
Spec: http://lbazan.fedorapeople.org/perl-Term-Animation.spec

http://koji.fedoraproject.org/koji/taskinfo?taskID=3166528

$ rpmlint -i *
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v *
perl-Term-Animation.noarch: I: checking
perl-Term-Animation.noarch: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.6.tar.gz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

SRPMS: http://lbazan.fedorapeople.org/perl-Term-Animation-2.6-6.fc15.src.rpm
SPEC:  http://lbazan.fedorapeople.org/perl-Term-Animation.spec

rpmlint perl-Term-Animation.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

[itamar@itamarssd perl-Term-Animation]$ rpmlint /home/itamar/rpmbuild/RPMS/noarch/perl-Term-Animation-2.6-6.fc15.noarch.rpm perl-Term-Animation-2.6-6.fc15.src.rpm 
perl-Term-Animation.src: W: strange-permission perl-Term-Animation.spec 0600L
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

-> chmod 644 perl-Term-Animation.spec

[ok] The package must be named according to the Package Naming Guidelines .
[ok] The spec file name must match the base package %{name}, in the format 
[ok] The package must meet the Packaging Guidelines .
[ok] The spec file must be written in American English. (habbla ingles)
[ok] The spec file for the package MUST be legible.     ( I am able to read)
[ok] The package MUST successfully compile and build into binary rpms on at least one primary architecture.
[ok] All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines inclusion of those as BuildRequires is optional
[ok] Packages must NOT bundle copies of system libraries.
[ok]A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. 
[ok]A Fedora package must not list a file more than once in the spec file's 
[ok] Each package must consistently use macros. [16]
[ok] The package must contain code, or permissable content.

[SHOULD-FIX] The package must be licensed with a Fedora approved license and meet the 

-> 
Licensing Guidelines .
-> current license : GPL+

http://cpansearch.perl.org/src/KBAUCOM/Term-Animation-2.6/README
This library is free software; you can redistribute it and/or modify
it under the same terms as Perl itself.

look - > https://fedoraproject.org/wiki/Packaging:Perl#License_tag
change to -> License:  GPL+ or Artistic


[SHOULD-FIX] - fix source url
-> https://fedoraproject.org/wiki/Packaging:Perl#URL_tag

change URL to -> URL: http://search.cpan.org/dist/perl-Term-Animation/

[SHOULD-FIX] - your %doc is empty.
I think you should add README and Changes file

change to -> %doc Changes README

URL SPEC: http://lbazan.fedorapeople.org/perl-Term-Animation.spec
URL SRPM: http://lbazan.fedorapeople.org/perl-Term-Animation-2.6-7.fc15.src.rpm 

chmod 644 perl-Term-Animation.spec ready

- change licences to GPL+ or Artistic
- fix URL
- add %doc Changes README

$ rpmlint -v perl-Term-Animation-2.6-7.fc15.src.rpm
perl-Term-Animation.src: I: checking
perl-Term-Animation.src: I: checking-url http://search.cpan.org/dist/perl-Term-Animation/ (timeout 10 seconds)
perl-Term-Animation.src: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.6.tar.gz (timeout 10 seconds)
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint perl-Term-Animation-2.6-7.fc15.src.rpm
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

$ rpmlint perl-Term-Animation.spec 
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

$ rpmlint -v perl-Term-Animation.spec 
perl-Term-Animation.spec: I: checking-url http://search.cpan.org/CPAN/authors/id/K/KB/KBAUCOM/Term-Animation-2.6.tar.gz (timeout 10 seconds)
0 packages and 1 specfiles checked; 0 errors, 0 warnings.

looks good for me,

PACKAGE APPROVED, PLEASE ASK FOR GIT ->

https://fedoraproject.org/wiki/Package_SCM_admin_requests#New_Packages

don't forget to add perl-sig into InitialCC -> 

https://fedoraproject.org/wiki/Packaging:Perl#Perl_SIG

New Package SCM Request
=======================
Package Name: perl-Term-Animation
Short Description:This module provides a framework to produce sprite animations using ASCII art. 
Owners: lbazan
Branches: f15
InitialCC: perl-sig

New Package SCM Request
=======================
Package Name: perl-Term-Animation
Short Description:ASCII sprite animation framework
Owners: lbazan
Branches: f15
InitialCC: perl-sig

Git done (by process-git-requests).

perl-Term-Animation-2.6-7.fc15 has been submitted as an update for Fedora 15.
https://admin.fedoraproject.org/updates/perl-Term-Animation-2.6-7.fc15

perl-Term-Animation-2.6-7.fc15 has been pushed to the Fedora 15 testing repository.

perl-Term-Animation-2.6-7.fc15 has been pushed to the Fedora 15 stable repository.